Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra clarity to the binary logic of the rules definitions #825

Closed
wants to merge 1 commit into from

Conversation

rogerluan
Copy link
Contributor

Resolves #815

@bobvanderlinden
Copy link
Owner

bobvanderlinden commented Aug 18, 2020

I personally think mentioning and and or in the readme might be confusing. It's true that all of the conditions of a rule must be true for the rule to pass and only one of the rules have to pass on order to trigger a auto-merge. I don't think mentioning and+or really helps in this case.

I say this partly because of #764 (comment), where rules also determine the behaviour of the merge and not just true/false.

@rogerluan
Copy link
Contributor Author

I personally think mentioning and and or in the readme might be confusing. It's true that all of the conditions of a rule must be true for the rule to pass and only one of the rules have to pass on order to trigger a auto-merge. I don't think mentioning and+or really helps in this case.

I say this partly because of #764 (comment), where rules also determine the behaviour of the merge and not just true/false.

Oh I didn't know that things other than Conditions could be used within the rules. Your point makes sense then.

I don't know how the documentation could be improved here then. I resolved my issue once you explained its behavior a little better, but maybe there're no changes to be made to the documentation then. If someone has issues understanding they'll probably find #815 and this PR itself :)

I'm gonna close this PR and #815 , at least for now 👍 thanks @bobvanderlinden !

@rogerluan rogerluan closed this Aug 20, 2020
@rogerluan rogerluan deleted the patch-1 branch August 20, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] "rules" usage is not clear
2 participants