Add maxPendingReviews condition

Closes #853

README.md

@@ -109,6 +109,20 @@ maxRequestedChanges:
   NONE: 0
 ```
 
+### `maxPendingReviews` (condition, default: .inf)
+
+Similar to `maxRequestedChanges`, maxPendingReviews determines the maximum number of
+non-completed reviews before a pull request will be blocked from being automatically
+merged.
+
+In the example below, automatic merges will be blocked when one of the owners, members
+or collaborators has not completed the requested review.
+
+```yaml
+maxPendingReviews:
+  COLLABORATOR: 0
+```
+
 ### `blockingBaseBranches` (condition, default: none)
 
 Whenever blocking base branches are configured, pull requests will only be automatically

auto-merge.example.yml

@@ -18,6 +18,14 @@ requiredReviewers:
 maxRequestedChanges:
   COLLABORATOR: 0
 
+# The maximum number of pending reviews from each association.
+# Setting this number to 0 will prevent automatic merging while not all reviewers have either
+# approved or requested changes..
+# Pending reviews from associations not defined in this list are ignored for automatic merging.
+# Dismissed reviews are ignored for automatic merging.
+maxPendingReviews:
+  COLLABORATOR: 0
+
 # Whether an out-of-date pull request is automatically updated.
 # It does so by merging its base on top of the head of the pull request.
 # This is the equivalent of clicking the 'Update branch' button.

src/conditions/index.ts

@@ -6,6 +6,7 @@ import blockingChecks from './blockingChecks'
 import blockingLabels from './blockingLabels'
 import blockingTitle from './blockingTitle'
 import maximumChangesRequested from './maximumChangesRequested'
+import maximumPendingReviews from './maximumPendingReviews'
 import mergeable from './mergeable'
 import minimumApprovals from './minimumApprovals'
 import requiredAuthorRole from './requiredAuthorRole'
@@ -24,6 +25,7 @@ export const conditions = {
   blockingLabels,
   blockingTitle,
   maximumChangesRequested,
+  maximumPendingReviews,
   mergeable,
   minimumApprovals,
   requiredAuthorRole,

src/config.ts

@@ -30,6 +30,7 @@ export type ConditionConfig = {
   minApprovals: { [key in CommentAuthorAssociation]?: number },
   requiredReviewers: string[],
   maxRequestedChanges: { [key in CommentAuthorAssociation]?: number },
+  maxPendingReviews: { [key in CommentAuthorAssociation]?: number },
   requiredBaseBranches: Pattern[],
   blockingBaseBranches: Pattern[],
   requiredLabels: Pattern[],
@@ -57,6 +58,8 @@ export const defaultRuleConfig: ConditionConfig = {
   maxRequestedChanges: {
     NONE: 0
   },
+  maxPendingReviews: {
+  },
   blockingBaseBranches: [],
   requiredBaseBranches: [],
   blockingLabels: [],
@@ -101,6 +104,7 @@ const conditionConfigDecoder: Decoder<ConditionConfig> = object({
   minApprovals: reviewConfigDecover,
   requiredReviewers: array(string()),
   maxRequestedChanges: reviewConfigDecover,
+  maxPendingReviews: reviewConfigDecover,
   requiredBaseBranches: array(patternDecoder),
   blockingBaseBranches: array(patternDecoder),
   requiredLabels: array(patternDecoder),
@@ -117,6 +121,7 @@ const configDecoder: Decoder<Config> = object({
   minApprovals: reviewConfigDecover,
   requiredReviewers: array(string()),
   maxRequestedChanges: reviewConfigDecover,
+  maxPendingReviews: reviewConfigDecover,
   requiredBaseBranches: array(patternDecoder),
   blockingBaseBranches: array(patternDecoder),
   requiredLabels: array(patternDecoder),

test/mock.ts

@@ -160,6 +160,16 @@ export function review (options: Partial<Review> & { state: PullRequestReviewSta
   }
 }
 
+export const pendingReview = (options?: Partial<Review>) =>
+  review({
+    state: PullRequestReviewState.PENDING,
+    ...options
+  })
+export const dismissedReview = (options?: Partial<Review>) =>
+  review({
+    state: PullRequestReviewState.DISMISSED,
+    ...options
+  })
 export const approvedReview = (options?: Partial<Review>) =>
   review({
     state: PullRequestReviewState.APPROVED,