Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined array key when argv doesn't exists #765

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

BafS
Copy link
Contributor

@BafS BafS commented Jul 26, 2023

In some cases $_SERVER['argv'] may not be set (I hit this issue with a project).

@bobthecow
Copy link
Owner

Good catch. We handle the missing argv case everywhere else, but this code is a ported and minimally modernized portion of a legacy library and we must have missed it when cleaning that up.

Thanks!

@bobthecow bobthecow merged commit 7b7cd62 into bobthecow:main Jul 28, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants