Implemented input completion for Userland #733
Conversation
zonuexe
force-pushed
the
feature/userland-readline-completion
branch
from
c97d27d to
7c4f8da
Compare
zonuexe
force-pushed
the
feature/userland-readline-completion
branch
from
7c4f8da to
0e5d28c
Compare
| public function useReadline(): bool | ||
| { | ||
| return isset($this->useReadline) ? ($this->hasReadline && $this->useReadline) : $this->hasReadline; | ||
| return isset($this->useReadline) ? ($this->hasNativeReadline && $this->useReadline) : $this->hasNativeReadline; |
There was a problem hiding this comment.
Maybe these should also be called "useNativeReadline", but I haven't changed them as they are separate issues from auto-completion.
| { | ||
| return '.'; | ||
| } | ||
| } |
There was a problem hiding this comment.
I left this adapter for interoperability with existing Hoa completions, but you can also remove HoaAutocompleter and make it directly dependent on Psy\TabCompletion\AutoCompleter. What do you think?
There was a problem hiding this comment.
what's the benefit of interoperability with existing Hoa completions? it's deprecated and unsupported, and the code here is effectively a stripped-down fork. i'm not sure i see the point :)
| /** | ||
| * Deactivete auto completer for tab completion. | ||
| */ | ||
| public function deactivateAutoCompleter(): void; |
There was a problem hiding this comment.
Do nothing for deactivate except native readline().
bobthecow
left a comment
bobthecow
left a comment
There was a problem hiding this comment.
Realistically we're a while from a release where we can introduce backwards compatibility breaks.
For better or worse, we need to maintain compatibility with the current AutoCompleter and Readline interfaces (though i'm not worried about anything in Psy\Readline\Hoa\*, that's an implementation detail not a public API 😛)
| public function deactivateAutoCompleter(): void | ||
| { | ||
| // PHP didn't implement the whole readline API when they first switched | ||
| // to libedit. And they still haven't. |
|
|
||
| $command = $term.'tput cols && '.$term.'tput lines'; | ||
| $tput = Processus::execute($command, false); | ||
| $tput = ConsoleProcessus::execute($command, false); |
| { | ||
| return '.'; | ||
| } | ||
| } |
There was a problem hiding this comment.
what's the benefit of interoperability with existing Hoa completions? it's deprecated and unsupported, and the code here is effectively a stripped-down fork. i'm not sure i see the point :)
| /** | ||
| * Activete auto completer for tab completion. | ||
| */ | ||
| public function activateAutoCompleter(AutoCompleter $autoCompleter): void; |
There was a problem hiding this comment.
let's make these two a second interface so we can maintain backwards compatibility for existing Readline API.
Co-authored-by: Justin Hileman <[email protected]>
| * @see https://www.php.net/readline_info | ||
| */ | ||
| public function complete(&$prefix); | ||
| public function complete(string $prefix, int $index, array $info); |
There was a problem hiding this comment.
these were passing by reference because they changed $prefix intentionally so the caller could check prefix length.
2 participants
refs #732