Add test for return type fix.

bobthecow · Jun 9, 2024 · c856125 · c856125
1 parent 1f2dc8d
commit c856125
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/src/CodeCleaner/ReturnTypePass.php b/src/CodeCleaner/ReturnTypePass.php
@@ -105,11 +105,7 @@ private function typeName(Node $node): string
             return \strtolower($node->type->name);
         }
 
-        if ($node instanceof Identifier) {
-            return \strtolower($node->name);
-        }
-
-        if ($node instanceof Name) {
+        if ($node instanceof Identifier || $node instanceof Name) {
             return \strtolower($node->name);
         }
 

diff --git a/test/CodeCleaner/ReturnTypePassTest.php b/test/CodeCleaner/ReturnTypePassTest.php
@@ -26,6 +26,22 @@ public function getReady()
         $this->setPass(new ReturnTypePass());
     }
 
+    /**
+     * @dataProvider happyPaths
+     */
+    public function testHappyPath($code)
+    {
+        $result = $this->parseAndTraverse($code);
+        $this->assertIsArray($result);
+    }
+
+    public function happyPaths()
+    {
+        return [
+            ['$x = function(): DateTime { return new DateTime(); };'],
+        ];
+    }
+
     /**
      * @dataProvider missingReturns
      */