Skip to content

Conversation

hpp2334
Copy link
Contributor

@hpp2334 hpp2334 commented Oct 3, 2025

This Pull Request fixes #4401.

The issue occurred because the binding was incorrectly classified as local, making it inaccessible during eval execution.

It changes the following:

  • for ordinary function, the contains_direct_eval apply to the entire subtree rather than just the node itself.

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 51.57%. Comparing base (6ddc2b4) to head (c35a52f).
⚠️ Report is 546 commits behind head on main.

Files with missing lines Patch % Lines
core/ast/src/operations/mod.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4453      +/-   ##
==========================================
+ Coverage   47.24%   51.57%   +4.33%     
==========================================
  Files         476      504      +28     
  Lines       46892    51382    +4490     
==========================================
+ Hits        22154    26502    +4348     
- Misses      24738    24880     +142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! @hpp2334 😄

@jedel1043 jedel1043 added ast Issue surrounding the abstract syntax tree hacktoberfest-accepted PR accepted for Hacktoberfest bug Something isn't working labels Oct 8, 2025
@jedel1043 jedel1043 added this pull request to the merge queue Oct 8, 2025
Merged via the queue into boa-dev:main with commit 109a9a4 Oct 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Issue surrounding the abstract syntax tree bug Something isn't working hacktoberfest-accepted PR accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic index out of bounds: the len is 0 but the index is 0 in core/engine/src/vm/opcode/get/name.rs
3 participants