-
-
Notifications
You must be signed in to change notification settings - Fork 456
Use same cache key for builds and tests #4426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Align cache keys across workflows to improve cache reuse and drop unsupported macOS 13 runners.
- Replace Swatinem/rust-cache with actions/cache and standardize keys to include OS, arch, and Cargo.lock hash
- Remove macOS 13 in matrices and update runners/targets accordingly
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
File | Description |
---|---|
.github/workflows/webassembly.yml | Replace rust-cache with actions/cache; adjust key; affects wasm build pipeline |
.github/workflows/test262_release.yml | Unify cache key to include runner arch |
.github/workflows/test262.yml | Unify cache key to include runner arch |
.github/workflows/rust.yml | Replace rust-cache with actions/cache across jobs; adjust matrix; update cache keys; remove macOS 13 |
.github/workflows/release.yml | Remove macOS AMD64 target; add cache step keyed by OS/arch; update runner images |
.github/workflows/pull_request.yml | Unify cache key to include runner arch |
.github/workflows/nightly_build.yml | Add arch to matrix entries; add cache step keyed by OS/arch; update runners |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4426 +/- ##
==========================================
+ Coverage 47.24% 51.21% +3.97%
==========================================
Files 476 502 +26
Lines 46892 51279 +4387
==========================================
+ Hits 22154 26265 +4111
- Misses 24738 25014 +276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I don't think it's necessary since both output to different folders, so it would not be much different to split them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why we need to modify the values for matrix
with the arch, if runner.arch
already has the arch name. Maybe we can skip modify those by just using runner.arch
everywhere?
We've been getting very little cache reuse from our cache keys, and the upstream action we're using doesn't support shared cache keys properly, so its easier to just use the basic cache action.
Question, should we split these by test and debug/release?