Add return_ssl_resources option to facebook module#265
Open
gilad61 wants to merge 1 commit intobnoguchi:masterfrom
Open
Add return_ssl_resources option to facebook module#265gilad61 wants to merge 1 commit intobnoguchi:masterfrom
gilad61 wants to merge 1 commit intobnoguchi:masterfrom
Conversation
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a https website all referenced urls (including images) must also be https to avoid mixed content warnings.
So when getting the Facebook '/me' object we should be able to tell Facebook that we want the returned resources to be prefixed with https rather than http.
See http://stackoverflow.com/questions/3199164/how-to-get-a-facebook-profile-picture-under-https