Skip to content

Fix https detection for Express 3#252

Open
nulltask wants to merge 1 commit intobnoguchi:express3from
nulltask:bug/detect-https-with-express3
Open

Fix https detection for Express 3#252
nulltask wants to merge 1 commit intobnoguchi:express3from
nulltask:bug/detect-https-with-express3

Conversation

@nulltask
Copy link

@nulltask nulltask commented May 3, 2012

Re pull request of #251. Thanks :)

@missinglink
Copy link

This is good, except I get an error if req.socket.socket is not defined.

The following works for me:

exports.extractHostname = function (req) {
  console.log(req.socket.socket !== undefined);
  var headers = req.headers
    , protocol = (req.connection.server instanceof tls.Server || 
                 (req.socket.socket !== undefined && req.socket.socket.server instanceof tls.Server) ||
                 req.headers['x-forwarded-proto'] == 'https')
               ? 'https://'
               : 'http://'
    , host = headers.host;
  return protocol + host;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants