Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Python 3.10 and 3.11, update actions #398

Closed

Conversation

willianrocha
Copy link
Contributor

A bit of CI maintenance:

  • Add Python 3.10 and 3.11 runs, and update the PyPy run to PyPy 3.9
  • Update the used actions to the latest versions
  • Also run on pushes, when manually triggered (workflow_dispatch)

I could not rebase and reuse the old PR #334

@willianrocha willianrocha force-pushed the ci_add_new_python_version branch 2 times, most recently from c805dc3 to 2f9d88b Compare October 2, 2023 21:46
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@cebc3f7). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #398   +/-   ##
=======================================
  Coverage        ?   86.97%           
=======================================
  Files           ?        2           
  Lines           ?      261           
  Branches        ?        0           
=======================================
  Hits            ?      227           
  Misses          ?       34           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willianrocha willianrocha marked this pull request as ready for review October 2, 2023 21:49
@willianrocha willianrocha changed the title CI: Add Python 3.10 and 3.11, update actions, run weekly CI: Add Python 3.10 and 3.11, update actions Oct 2, 2023
@fredgrub
Copy link
Contributor

fredgrub commented Oct 4, 2023

You should mention the PR (and the author) in the commit. According to Alan's suggestion in #396 (comment).

@alan-barzilay
Copy link
Collaborator

https://docs.python.org/3.12/whatsnew/3.12.html

add python 3.12 please

@alan-barzilay
Copy link
Collaborator

actually, please use all supported pythonv ersions and remove unsupported ones

https://devguide.python.org/versions/

Copy link
Collaborator

@alan-barzilay alan-barzilay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alongside the changes requested, please also add in the commit message a mention to the updated action version

@willianrocha willianrocha force-pushed the ci_add_new_python_version branch 3 times, most recently from df8b943 to 650917c Compare October 10, 2023 00:05
A bit of CI maintenance:
- Add Python 3.10 and 3.11 runs, and update the PyPy run to PyPy 3.9
- Removed Python 3.7 as it is deprecated
- Update the used actions (checkout and setup-python) to the latest versions
- Also run on pushes, when manually triggered (workflow_dispatch)

The original PR was done by @EwoutH at bndr#334
herati pushed a commit to pipreqsxp/pipreqs that referenced this pull request Oct 12, 2023
- The pypy v7.3.13, used by GitHub Actions, was failing. So I force to use pypy v7.3.12 that was passing.
- The original PR was done by @EwoutH at bndr#334 and modified by @willianrocha at bndr#398.
alan-barzilay pushed a commit that referenced this pull request Oct 12, 2023
- The pypy v7.3.13, used by GitHub Actions, was failing. So I force to use pypy v7.3.12 that was passing.
- The original PR was done by @EwoutH at #334 and modified by @willianrocha at #398.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants