handle FileNotFoundError in parse_requirements function #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is related to PR #392. Since this PR modifies the functioning of the |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## next #397 +/- ##
==========================================
+ Coverage 89.96% 90.07% +0.11%
==========================================
Files 2 2
Lines 259 262 +3
==========================================
+ Hits 233 236 +3
Misses 26 26
☔ View full report in Codecov by Sentry. |
|
LGTM just remove the white trailing space please |
|
ah, and rebase, thx |
mateuslatrova
force-pushed
the
handle_exception
branch
2 times, most recently
from
63e5baf
to
8f351c6
Compare
|
@alan-barzilay rebased and fixed the white trailing space. |
mateuslatrova
force-pushed
the
handle_exception
branch
from
8f351c6
to
4bb7f3e
Compare
alan-barzilay
requested changes
Oct 10, 2023
mateuslatrova
force-pushed
the
handle_exception
branch
from
4bb7f3e
to
4a28ae7
Compare
alan-barzilay
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the function "parse_requirements.txt" does not find the file passed as a parameter, it just raises an OSError.
This PR changes that behavior. Now, when that happens, this function handles it by printing a helpful message to the user and ends the program execution immediately.