Skip to content

[TEMPLATE] add FastAPI-fastkit dependency at all templates #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnbong merged 1 commit into from
Oct 20, 2025
Merged

[TEMPLATE] add FastAPI-fastkit dependency at all templates #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/fastapi_fastkit/fastapi_project_template/fastapi-async-crud/pyproject.toml-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ authors = [
]
readme = "README.md"
license = "MIT"
requires-python = ">=3.9"
requires-python = ">=3.12"
dependencies = [
"fastapi>=0.115.8",
"uvicorn[standard]>=0.34.0",
Expand All @@ -16,6 +16,7 @@ dependencies = [
"SQLAlchemy>=2.0.38",
"python-dotenv>=1.0.1",
"aiofiles>=24.1.0",
"fastapi-fastkit>=1.1.5",
]

[project.optional-dependencies]
Expand Down
1 change: 1 addition & 0 deletions src/fastapi_fastkit/fastapi_project_template/fastapi-async-crud/requirements.txt-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ uvloop==0.21.0
watchfiles==1.0.4
websockets==15.0
aiofiles>=24.1.0
FastAPI-fastkit==1.1.5
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Use the normalized lowercase package name: fastapi-fastkit==1.1.5.

Suggested change
FastAPI-fastkit==1.1.5
fastapi-fastkit==1.1.5

Copilot uses AI. Check for mistakes.
3 changes: 2 additions & 1 deletion src/fastapi_fastkit/fastapi_project_template/fastapi-custom-response/pyproject.toml-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ authors = [
]
readme = "README.md"
license = "MIT"
requires-python = ">=3.9"
requires-python = ">=3.12"
dependencies = [
"fastapi>=0.115.8",
"uvicorn[standard]>=0.34.0",
Expand All @@ -16,6 +16,7 @@ dependencies = [
"SQLAlchemy>=2.0.38",
"python-dotenv>=1.0.1",
"aiofiles>=24.1.0",
"fastapi-fastkit>=1.1.5",
]

[project.optional-dependencies]
Expand Down
1 change: 1 addition & 0 deletions src/fastapi_fastkit/fastapi_project_template/fastapi-custom-response/requirements.txt-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ uvicorn==0.34.0
uvloop==0.21.0
watchfiles==1.0.4
websockets==15.0
FastAPI-fastkit==1.1.5
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Lowercase the package name to align with standard normalization and the corresponding pyproject entry: fastapi-fastkit==1.1.5.

Suggested change
FastAPI-fastkit==1.1.5
fastapi-fastkit==1.1.5

Copilot uses AI. Check for mistakes.
3 changes: 2 additions & 1 deletion src/fastapi_fastkit/fastapi_project_template/fastapi-default/pyproject.toml-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@ authors = [
]
readme = "README.md"
license = "MIT"
requires-python = ">=3.9"
requires-python = ">=3.12"
dependencies = [
"fastapi>=0.115.8",
"uvicorn[standard]>=0.34.0",
"pydantic>=2.10.6",
"pydantic-settings>=2.7.1",
"SQLAlchemy>=2.0.38",
"python-dotenv>=1.0.1",
"fastapi-fastkit>=1.1.5",
]

[project.optional-dependencies]
Expand Down
1 change: 1 addition & 0 deletions src/fastapi_fastkit/fastapi_project_template/fastapi-default/requirements.txt-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ uvicorn==0.34.0
uvloop==0.21.0
watchfiles==1.0.4
websockets==15.0
FastAPI-fastkit==1.1.5
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Please use lowercase for the dependency name for consistency across files: fastapi-fastkit==1.1.5.

Suggested change
FastAPI-fastkit==1.1.5
fastapi-fastkit==1.1.5

Copilot uses AI. Check for mistakes.
3 changes: 2 additions & 1 deletion src/fastapi_fastkit/fastapi_project_template/fastapi-dockerized/pyproject.toml-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ authors = [
]
readme = "README.md"
license = "MIT"
requires-python = ">=3.9"
requires-python = ">=3.12"
dependencies = [
"fastapi>=0.115.8",
"uvicorn[standard]>=0.34.0",
Expand All @@ -16,6 +16,7 @@ dependencies = [
"SQLAlchemy>=2.0.38",
"sqlmodel>=0.0.22",
"python-dotenv>=1.0.1",
"fastapi-fastkit>=1.1.5",
]

[project.optional-dependencies]
Expand Down
1 change: 1 addition & 0 deletions src/fastapi_fastkit/fastapi_project_template/fastapi-dockerized/requirements.txt-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ uvicorn==0.34.0
uvloop==0.21.0
watchfiles==1.0.4
websockets==15.0
FastAPI-fastkit==1.1.5
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Normalize package casing to lowercase to match pyproject and packaging norms: fastapi-fastkit==1.1.5.

Suggested change
FastAPI-fastkit==1.1.5
fastapi-fastkit==1.1.5

Copilot uses AI. Check for mistakes.
3 changes: 2 additions & 1 deletion src/fastapi_fastkit/fastapi_project_template/fastapi-empty/pyproject.toml-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ authors = [
]
readme = "README.md"
license = "MIT"
requires-python = ">=3.9"
requires-python = ">=3.12"
dependencies = [
"fastapi>=0.115.8",
"uvicorn[standard]>=0.34.0",
"pydantic>=2.10.6",
"pydantic-settings>=2.7.1",
"fastapi-fastkit>=1.1.5",
]

[project.optional-dependencies]
Expand Down
1 change: 1 addition & 0 deletions src/fastapi_fastkit/fastapi_project_template/fastapi-empty/requirements.txt-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ black==25.1.0
isort==6.0.0
mypy==1.15.0
setuptools==80.9.0
FastAPI-fastkit==1.1.5
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Switch to lowercase package name for consistency: fastapi-fastkit==1.1.5.

Suggested change
FastAPI-fastkit==1.1.5
fastapi-fastkit==1.1.5

Copilot uses AI. Check for mistakes.
3 changes: 2 additions & 1 deletion src/fastapi_fastkit/fastapi_project_template/fastapi-mcp/pyproject.toml-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ authors = [
]
readme = "README.md"
license = "MIT"
requires-python = ">=3.10"
requires-python = ">=3.12"
dependencies = [
"fastapi>=0.115.8",
"uvicorn[standard]>=0.34.0",
Expand All @@ -20,6 +20,7 @@ dependencies = [
"passlib>=1.7.4",
"python-jose>=3.3.0",
"python-multipart>=0.0.17",
"fastapi-fastkit>=1.1.5",
]

[project.optional-dependencies]
Expand Down
1 change: 1 addition & 0 deletions src/fastapi_fastkit/fastapi_project_template/fastapi-mcp/requirements.txt-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,4 @@ uvicorn==0.34.0
uvloop==0.21.0
watchfiles==1.0.4
websockets==15.0
FastAPI-fastkit==1.1.5
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Package names should be lowercase; update to fastapi-fastkit==1.1.5 for consistency and adherence to packaging conventions.

Suggested change
FastAPI-fastkit==1.1.5
fastapi-fastkit==1.1.5

Copilot uses AI. Check for mistakes.
3 changes: 2 additions & 1 deletion src/fastapi_fastkit/fastapi_project_template/fastapi-psql-orm/pyproject.toml-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ authors = [
]
readme = "README.md"
license = "MIT"
requires-python = ">=3.9"
requires-python = ">=3.12"
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This raises the floor from >=3.9 to >=3.12. If not strictly required by dependencies, keep the previous minimum to avoid unnecessarily limiting users, or add justification in docs/PR.

Suggested change
requires-python = ">=3.12"
requires-python = ">=3.9"

Copilot uses AI. Check for mistakes.
dependencies = [
"fastapi>=0.115.8",
"uvicorn[standard]>=0.34.0",
Expand All @@ -19,6 +19,7 @@ dependencies = [
"alembic>=1.14.1",
"psycopg[binary]>=3.2.5",
"tenacity>=9.0.0",
"fastapi-fastkit>=1.1.5",
]

[project.optional-dependencies]
Expand Down
1 change: 1 addition & 0 deletions src/fastapi_fastkit/fastapi_project_template/fastapi-psql-orm/requirements.txt-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,4 @@ uvicorn==0.34.0
uvloop==0.21.0
watchfiles==1.0.4
websockets==15.0
FastAPI-fastkit==1.1.5
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Use lowercase for the package name to align with normalized package naming and match pyproject.toml: fastapi-fastkit==1.1.5.

Suggested change
FastAPI-fastkit==1.1.5
fastapi-fastkit==1.1.5

Copilot uses AI. Check for mistakes.
3 changes: 2 additions & 1 deletion src/fastapi_fastkit/fastapi_project_template/fastapi-single-module/pyproject.toml-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ authors = [
]
readme = "README.md"
license = "MIT"
requires-python = ">=3.9"
requires-python = ">=3.12"
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Raising the minimum Python version from >=3.9 to >=3.12 is a breaking change for template consumers. Unless fastapi-fastkit 1.1.5 requires 3.12, consider keeping >=3.9 or document/justify the restriction in the PR and template docs.

Suggested change
requires-python = ">=3.12"
requires-python = ">=3.9"

Copilot uses AI. Check for mistakes.
dependencies = [
"fastapi>=0.115.8",
"uvicorn[standard]>=0.34.0",
"fastapi-fastkit>=1.1.5",
]

[dependency-groups]
Expand Down
1 change: 1 addition & 0 deletions src/fastapi_fastkit/fastapi_project_template/fastapi-single-module/requirements.txt-tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ pydantic==2.10.6
pydantic-settings==2.7.1
pytest==8.3.4
httpx==0.28.1
FastAPI-fastkit==1.1.5
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Normalize the package name to lowercase to match canonical PEP 503 normalization and to be consistent with pyproject.toml in this template: use fastapi-fastkit==1.1.5.

Suggested change
FastAPI-fastkit==1.1.5
fastapi-fastkit==1.1.5

Copilot uses AI. Check for mistakes.
Loading