feat: clean deprecated code

contracts/GovHub.sol

@@ -31,26 +31,17 @@ contract GovHub is System, IApplication {
         uint8,
         bytes calldata msgBytes
     ) external override onlyCrossChainContract returns (bytes memory responsePayload) {
-        (ParamChangePackage memory proposal, bool success) = decodeSynPackage(msgBytes);
-        if (!success) {
-            return CmnPkg.encodeCommonAckPackage(ERROR_FAIL_DECODE);
-        }
-        uint32 resCode = notifyUpdates(proposal);
-        if (resCode == CODE_OK) {
-            return new bytes(0);
-        } else {
-            return CmnPkg.encodeCommonAckPackage(resCode);
-        }
+        revert("deprecated");
     }
 
     // should not happen
     function handleAckPackage(uint8, bytes calldata) external override onlyCrossChainContract {
-        require(false, "receive unexpected ack package");
+        revert("deprecated");
     }
 
     // should not happen
     function handleFailAckPackage(uint8, bytes calldata) external override onlyCrossChainContract {
-        require(false, "receive unexpected fail ack package");
+        revert("deprecated");
     }
 
     function updateParam(string calldata key, bytes calldata value, address target) external onlyGovernorTimelock {
@@ -73,27 +64,4 @@ contract GovHub is System, IApplication {
         }
         return CODE_OK;
     }
-
-    //rlp encode & decode function
-    function decodeSynPackage(bytes memory msgBytes) internal pure returns (ParamChangePackage memory, bool) {
-        ParamChangePackage memory pkg;
-
-        RLPDecode.Iterator memory iter = msgBytes.toRLPItem().iterator();
-        bool success = false;
-        uint256 idx = 0;
-        while (iter.hasNext()) {
-            if (idx == 0) {
-                pkg.key = string(iter.next().toBytes());
-            } else if (idx == 1) {
-                pkg.value = iter.next().toBytes();
-            } else if (idx == 2) {
-                pkg.target = iter.next().toAddress();
-                success = true;
-            } else {
-                break;
-            }
-            ++idx;
-        }
-        return (pkg, success);
-    }
 }

contracts/SlashIndicator.sol

@@ -94,22 +94,15 @@ contract SlashIndicator is ISlashIndicator, System, IParamSubscriber, IApplicati
         uint8,
         bytes calldata
     ) external override onlyCrossChainContract onlyInit returns (bytes memory) {
-        require(false, "receive unexpected syn package");
+        revert("deprecated");
     }
 
     function handleAckPackage(uint8, bytes calldata msgBytes) external override onlyCrossChainContract onlyInit {
-        (CmnPkg.CommonAckPackage memory response, bool ok) = CmnPkg.decodeCommonAckPackage(msgBytes);
-        if (ok) {
-            emit knownResponse(response.code);
-        } else {
-            emit unKnownResponse(response.code);
-        }
-        return;
+        revert("deprecated");
     }
 
     function handleFailAckPackage(uint8, bytes calldata) external override onlyCrossChainContract onlyInit {
-        emit crashResponse();
-        return;
+        revert("deprecated");
     }
 
     /*----------------- External func -----------------*/
@@ -134,16 +127,7 @@ contract SlashIndicator is ISlashIndicator, System, IParamSubscriber, IApplicati
         if (indicator.count % felonyThreshold == 0) {
             indicator.count = 0;
             IBSCValidatorSet(VALIDATOR_CONTRACT_ADDR).felony(validator);
-            if (IStakeHub(STAKE_HUB_ADDR).consensusToOperator(validator) != address(0)) {
-                _downtimeSlash(validator, indicator.count, false);
-            } else {
-                // send slash msg to bc if validator is not migrated
-                try ICrossChain(CROSS_CHAIN_CONTRACT_ADDR).sendSynPackage(
-                    SLASH_CHANNELID, encodeSlashPackage(validator), 0
-                ) { } catch (bytes memory reason) {
-                    emit failedFelony(validator, indicator.count, reason);
-                }
-            }
+            _downtimeSlash(validator, indicator.count, false);
         } else if (indicator.count % misdemeanorThreshold == 0) {
             IBSCValidatorSet(VALIDATOR_CONTRACT_ADDR).misdemeanor(validator);
         }
@@ -284,17 +268,7 @@ contract SlashIndicator is ISlashIndicator, System, IParamSubscriber, IApplicati
             }
         }
 
-        if (IStakeHub(STAKE_HUB_ADDR).voteToOperator(_evidence.voteAddr) != address(0)) {
-            IStakeHub(STAKE_HUB_ADDR).maliciousVoteSlash(_evidence.voteAddr);
-        } else {
-            // send slash msg to bc if the validator not migrated
-            ICrossChain(CROSS_CHAIN_CONTRACT_ADDR).sendSynPackage(
-                SLASH_CHANNELID, encodeVoteSlashPackage(_evidence.voteAddr), 0
-            );
-
-            bytes32 voteAddrSlice = BytesLib.toBytes32(_evidence.voteAddr, 0);
-            emit maliciousVoteSlashed(voteAddrSlice);
-        }
+        IStakeHub(STAKE_HUB_ADDR).maliciousVoteSlash(_evidence.voteAddr);
     }
 
     function submitDoubleSignEvidence(bytes memory header1, bytes memory header2) public onlyInit {
@@ -343,10 +317,7 @@ contract SlashIndicator is ISlashIndicator, System, IParamSubscriber, IApplicati
      * @param validator Who will be jailed
      */
     function sendFelonyPackage(address validator) external override(ISlashIndicator) onlyValidatorContract onlyInit {
-        try ICrossChain(CROSS_CHAIN_CONTRACT_ADDR).sendSynPackage(SLASH_CHANNELID, encodeSlashPackage(validator), 0) { }
-        catch (bytes memory reason) {
-            emit failedFelony(validator, 0, reason);
-        }
+        emit failedFelony(validator, 0, "deprecated");
     }
 
     function _verifyBLSSignature(VoteData memory vote, bytes memory voteAddr) internal view returns (bool) {

contracts/StakeHub.sol

@@ -8,10 +8,8 @@ import "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol";
 import "./SystemV2.sol";
 import "./extension/Protectable.sol";
 import "./interface/0.8.x/IBSCValidatorSet.sol";
-import "./interface/0.8.x/ICrossChain.sol";
 import "./interface/0.8.x/IGovToken.sol";
 import "./interface/0.8.x/IStakeCredit.sol";
-import "./interface/0.8.x/ITokenHub.sol";
 import "./lib/0.8.x/RLPDecode.sol";
 import "./lib/0.8.x/Utils.sol";
 
@@ -283,45 +281,15 @@ contract StakeHub is SystemV2, Initializable, Protectable {
         uint8,
         bytes calldata msgBytes
     ) external onlyCrossChainContract whenNotPaused enableReceivingFund returns (bytes memory) {
-        (StakeMigrationPackage memory migrationPkg, bool decodeSuccess) = _decodeMigrationSynPackage(msgBytes);
-        if (!decodeSuccess) revert InvalidSynPackage();
-
-        if (migrationPkg.amount == 0) {
-            return new bytes(0);
-        }
-
-        // claim fund from TokenHub
-        bool claimSuccess = ITokenHub(TOKEN_HUB_ADDR).claimMigrationFund(migrationPkg.amount);
-        if (!claimSuccess) {
-            emit MigrateFailed(
-                migrationPkg.operatorAddress,
-                migrationPkg.delegator,
-                migrationPkg.amount,
-                StakeMigrationRespCode.CLAIM_FUND_FAILED
-            );
-            return msgBytes;
-        }
-
-        StakeMigrationRespCode respCode = _doMigration(migrationPkg);
-
-        if (respCode == StakeMigrationRespCode.MIGRATE_SUCCESS) {
-            return new bytes(0);
-        } else {
-            (bool success,) = TOKEN_HUB_ADDR.call{ value: address(this).balance }("");
-            if (!success) revert TransferFailed();
-            emit MigrateFailed(migrationPkg.operatorAddress, migrationPkg.delegator, migrationPkg.amount, respCode);
-            return msgBytes;
-        }
+        revert("deprecated");
     }
 
     function handleAckPackage(uint8 channelId, bytes calldata msgBytes) external onlyCrossChainContract {
-        // should not happen
-        emit UnexpectedPackage(channelId, msgBytes);
+        revert("deprecated");
     }
 
     function handleFailAckPackage(uint8 channelId, bytes calldata msgBytes) external onlyCrossChainContract {
-        // should not happen
-        emit UnexpectedPackage(channelId, msgBytes);
+        revert("deprecated");
     }
 
     /*----------------- external functions -----------------*/
@@ -1031,57 +999,6 @@ contract StakeHub is SystemV2, Initializable, Protectable {
     }
 
     /*----------------- internal functions -----------------*/
-    function _decodeMigrationSynPackage(
-        bytes memory msgBytes
-    ) internal pure returns (StakeMigrationPackage memory, bool) {
-        StakeMigrationPackage memory migrationPackage;
-
-        RLPDecode.Iterator memory iter = msgBytes.toRLPItem().iterator();
-        bool success = false;
-        uint256 idx = 0;
-        while (iter.hasNext()) {
-            if (idx == 0) {
-                migrationPackage.operatorAddress = address(uint160(iter.next().toAddress()));
-            } else if (idx == 1) {
-                migrationPackage.delegator = address(uint160(iter.next().toAddress()));
-            } else if (idx == 2) {
-                migrationPackage.refundAddress = address(uint160(iter.next().toAddress()));
-            } else if (idx == 3) {
-                migrationPackage.amount = iter.next().toUint();
-                success = true;
-            } else {
-                break;
-            }
-            ++idx;
-        }
-
-        return (migrationPackage, success);
-    }
-
-    function _doMigration(StakeMigrationPackage memory migrationPkg) internal returns (StakeMigrationRespCode) {
-        if (blackList[migrationPkg.delegator] || migrationPkg.delegator == address(0)) {
-            return StakeMigrationRespCode.INVALID_DELEGATOR;
-        }
-
-        if (!_validatorSet.contains(migrationPkg.operatorAddress)) {
-            return StakeMigrationRespCode.VALIDATOR_NOT_EXISTED;
-        }
-
-        Validator memory valInfo = _validators[migrationPkg.operatorAddress];
-        if (valInfo.jailed && migrationPkg.delegator != migrationPkg.operatorAddress) {
-            return StakeMigrationRespCode.VALIDATOR_JAILED;
-        }
-
-        uint256 shares =
-            IStakeCredit(valInfo.creditContract).delegate{ value: migrationPkg.amount }(migrationPkg.delegator);
-        emit Delegated(migrationPkg.operatorAddress, migrationPkg.delegator, shares, migrationPkg.amount);
-        emit MigrateSuccess(migrationPkg.operatorAddress, migrationPkg.delegator, shares, migrationPkg.amount);
-
-        IGovToken(GOV_TOKEN_ADDR).sync(valInfo.creditContract, migrationPkg.delegator);
-
-        return StakeMigrationRespCode.MIGRATE_SUCCESS;
-    }
-
     function _checkMoniker(string memory moniker) internal pure returns (bool) {
         bytes memory bz = bytes(moniker);
 
@@ -1175,20 +1092,12 @@ contract StakeHub is SystemV2, Initializable, Protectable {
     }
 
     function _jailValidator(Validator storage valInfo, uint256 jailUntil) internal {
-        IBSCValidatorSet(VALIDATOR_CONTRACT_ADDR).removeTmpMigratedValidator(valInfo.consensusAddress);
-
         // keep the last eligible validator
         bool isLast = (numOfJailed >= _validatorSet.length() - 1);
         if (isLast) {
             // If staking channel is closed, then BC-fusion is finished and we should keep the last eligible validator here
-            if (
-                !ICrossChain(CROSS_CHAIN_CONTRACT_ADDR).registeredContractChannelMap(
-                    VALIDATOR_CONTRACT_ADDR, STAKING_CHANNELID
-                )
-            ) {
-                emit ValidatorEmptyJailed(valInfo.operatorAddress);
-                return;
-            }
+            emit ValidatorEmptyJailed(valInfo.operatorAddress);
+            return;
         }
 
         if (jailUntil > valInfo.jailUntil) {