feat: add agent address for validators #568
Conversation
contracts/BC_fusion/StakeHub.sol
Outdated
| @@ -1179,4 +1208,12 @@ contract StakeHub is System, Initializable, Protectable { | |||
| uint256 bnbAmount = IStakeCredit(_validators[operatorAddress].creditContract).claim(msg.sender, requestNumber); | |||
| emit Claimed(operatorAddress, msg.sender, bnbAmount); | |||
| } | |||
|
|
|||
| function _getMsgSender() internal view returns (address) { | |||
There was a problem hiding this comment.
It may be better use _getOperatorFromMsgSender
There was a problem hiding this comment.
_getOperatorFromMsgSender may be inaccurate. In most cases, msg.sender is returned directly, and in rare cases, the agent can appear as a msg.sender replacement for the operatorAddress.
There was a problem hiding this comment.
_getOperatorByMsgSender？
There was a problem hiding this comment.
This method is not to get operator address, it's to get the real msg.sender for all address. Only in some scenarios, the agent can be the msg.sender of the operatorAddress .
There was a problem hiding this comment.
we can refer to the similar code here: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/05f218fb6617932e56bf5388c3b389c3028a7b73/contracts/metatx/ERC2771Context.sol#L55
_msgSender is used to replace the msg.sender and
_getMsgSender is also used to replace the msg.sender
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Description
add agent address for validators
Rationale
Agent can execute
editConsensusAddress,editCommissionRate,editDescription,editVoteAddressfor his operator.Changes
Notable changes: