Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define turnLength and systemRewardAntiMEVRatio for BEP-341 #562

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: define turnLength and systemRewardAntiMEVRatio for BEP-341 #562

wants to merge 1 commit into from

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented May 22, 2024 •
edited by buddh0
Loading

Description

feat: define turnLength and systemRewardAntiMEVRatio for BEP-341

Rationale

tell us why we need these changes...

Example

two tests will pass by following command

cd contracts 
forge test --match-test testDeposit --match-contract ValidatorSetTest
forge test --match-test testGov --match-contract ValidatorSetTest

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch from 8e9c8d2 to 643e917 Compare May 22, 2024 07:29
@NathanBSC NathanBSC changed the base branch from master to fix_part_unit_tests May 22, 2024 07:29
@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch from 643e917 to ebefd4c Compare May 22, 2024 08:06
@NathanBSC NathanBSC changed the title BEP-341: define turnTerm and antiMEVSystemRewardRatio feat: define turnTerm and antiMEVSystemRewardRatio for BEP-341 May 22, 2024
@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch 3 times, most recently from 5f15782 to a977759 Compare May 29, 2024 03:15
@NathanBSC NathanBSC changed the title feat: define turnTerm and antiMEVSystemRewardRatio for BEP-341 feat: define turnTerm and systemRewardAntiMEVRatio for BEP-341 May 29, 2024
@buddh0 buddh0 force-pushed the BEP-341-produce-consecutive-blocks branch from a977759 to 9848397 Compare June 3, 2024 08:24
@buddh0 buddh0 changed the base branch from fix_part_unit_tests to develop June 3, 2024 08:24
@buddh0 buddh0 changed the base branch from develop to master June 3, 2024 08:24
@buddh0 buddh0 changed the base branch from master to develop June 3, 2024 08:32
@buddh0 buddh0 changed the base branch from develop to master June 3, 2024 08:42
@buddh0 buddh0 changed the base branch from master to develop June 3, 2024 12:54
@buddh0 buddh0 marked this pull request as ready for review June 3, 2024 12:54
@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch from 43e2b8b to 720f5b6 Compare June 27, 2024 10:35
@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch from 720f5b6 to f9d1a0c Compare June 28, 2024 01:43
@buddh0 buddh0 changed the title feat: define turnTerm and systemRewardAntiMEVRatio for BEP-341 feat: define turnLength and systemRewardAntiMEVRatio for BEP-341 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro left review comments

@buddh0 buddh0 buddh0 left review comments

@emailtovamos emailtovamos emailtovamos left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NathanBSC @unclezoro @buddh0 @emailtovamos