chore: disable editing moniker (#442)

bnb-chain · Dec 12, 2023 · 5d9b19a · 5d9b19a
1 parent 3ca5fa6
commit 5d9b19a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 22 deletions.
diff --git a/contracts/BC_fusion/StakeHub.sol b/contracts/BC_fusion/StakeHub.sol
@@ -354,20 +354,20 @@ contract StakeHub is System, Initializable {
     }
 
     /**
+     * @notice the moniker of the validator will be ignored as it is not editable
      * @param description the new description of the validator
      */
-    function editDescription(Description calldata description)
+    function editDescription(Description memory description)
         external
         whenNotPaused
         notInBlackList
         validatorExist(msg.sender)
     {
-        if (!_checkMoniker(description.moniker)) revert InvalidMoniker();
-
         address operatorAddress = msg.sender;
         Validator storage valInfo = _validators[operatorAddress];
         if (valInfo.updateTime + BREATH_BLOCK_INTERVAL > block.timestamp) revert UpdateTooFrequently();
 
+        description.moniker = valInfo.description.moniker;
         valInfo.description = description;
         valInfo.updateTime = block.timestamp;
 

diff --git a/test/StakeHub.t.sol b/test/StakeHub.t.sol
@@ -67,30 +67,14 @@ contract StakeHubTest is Deployer {
         // 4. edit description
         vm.warp(block.timestamp + 1 days);
         StakeHub.Description memory description = stakeHub.getValidatorDescription(validator);
-        // invalid moniker
-        description.moniker = "test";
-        vm.expectRevert();
-        stakeHub.editDescription(description);
-
-        description.moniker = "T";
-        vm.expectRevert();
-        stakeHub.editDescription(description);
-
-        description.moniker = "Test;";
-        vm.expectRevert();
-        stakeHub.editDescription(description);
-
-        description.moniker = "Test ";
-        vm.expectRevert();
-        stakeHub.editDescription(description);
-
-        // valid moniker
         description.moniker = "Test";
+        description.website = "Test";
         vm.expectEmit(true, false, false, true, address(stakeHub));
         emit DescriptionEdited(validator);
         stakeHub.editDescription(description);
         StakeHub.Description memory realDesc = stakeHub.getValidatorDescription(validator);
-        assertEq(realDesc.moniker, "Test");
+        assertNotEq(realDesc.moniker, "Test"); // edit moniker is not allowed
+        assertEq(realDesc.website, "Test");
 
         // 5. edit vote address
         vm.warp(block.timestamp + 1 days);