Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify passphrase grep check #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aureliojargas
Copy link

Since grep returns with exit code 0 when the search string is found, it can be used directly on the if.

Also, using the -s option there's no need to check if the file exists.

Since `grep` returns with exit code 0 when the search string is found, it can
be used directly on the `if`.

Also, using the `-s` option there's no need to check if the file exists.
@jongiddy
Copy link
Contributor

Thanks for the suggestion. This line is also modified in #90 so I'd suggest we consider making this change after that has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants