Add button type to toggle and toggle group button

[bluzky]

Summary by Sourcery

Add type="button" to toggle and toggle group buttons to prevent accidental form submissions.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request adds the type="button" attribute to the toggle and toggle group buttons. This ensures that the buttons do not submit forms when they are clicked.

Sequence diagram showing form submission prevention with button type

sequenceDiagram
    actor User
    participant Toggle
    participant Form
    Note over User,Form: Before: Button could submit form
    User->>Toggle: Click toggle button
    Toggle->>Form: Unintended form submission
    Note over User,Form: After: Button type prevents submission
    User->>Toggle: Click toggle button
    Toggle-->>Toggle: Handle toggle state
    Note right of Toggle: No form submission occurs

Loading

Class diagram showing updated Toggle and ToggleGroup components

classDiagram
    class Toggle {
        +render(assigns)
        note for Toggle "Added type='button' to button element"
    }
    class ToggleGroup {
        +render_button(assigns)
        +render_button_with_icon(assigns)
        note for ToggleGroup "Added type='button' to both button variants"
    }
    ToggleGroup --> Toggle

Loading

File-Level Changes

Change	Details	Files
Added the type="button" attribute to the toggle button.	Added type="button" to the button element in SaladUI.Toggle component	lib/salad_ui/toggle.ex
Added the type="button" attribute to the toggle group button.	Added type="button" to the button element in SaladUI.ToggleGroup component Added type="button" to the button element in SaladUI.ToggleGroup.Item component	lib/salad_ui/toggle_group.ex

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @bluzky - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}