-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Integrate Zag.js to improve acessibility #104
Draft
bluzky
wants to merge
75
commits into
main
Choose a base branch
from
feature/accessibility-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,155
−400
Draft
Changes from 7 commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
c7da662
add files related to zag
selenil 3a85322
modify cli to work with zag hook
selenil 34d187e
add unique_id helper
selenil 9eb93f1
make collapsible component accessible
selenil b70fb82
fix some issues
selenil 65f780a
Merge branch 'feature/accessibility-hook' into feature/accessibility-…
bluzky a9752bc
Merge pull request #87 from selenil/feature/accessibility-hook
bluzky 293dfed
fix collapsible
bluzky 7bec0ca
Merge branch 'main' into feature/accessibility-hook
bluzky ba5be74
WIP
bluzky b3027cc
WIP
bluzky 6da12eb
Improve select
bluzky 0d0e307
Improve select with zag hook
bluzky a9a790d
Fix select with zag
bluzky d9d29f7
Merge pull request #103 from bluzky/feature/select-accessibility
bluzky f6b9346
Clean unused code
bluzky 2ef5118
Merge pull request #108 from bluzky/feature/select-accessibility
bluzky fce00ef
Merge remote-tracking branch 'origin/main' into feature/accessibility…
bluzky 1d25dc9
Fix hidden at loading
bluzky 5d40409
Update select
bluzky c3b8bc7
Update js with fixes when testing on storybook
bluzky 6fb81ed
Improve JS code for component
bluzky c611c20
Merge pull request #109 from bluzky/feature/acessibility-improve-select
bluzky 9cb9ec9
WIP
selenil d4078f1
Improve Toggle group accessibility
bluzky 941aa82
Merge pull request #111 from bluzky/feature/accessibility-toggle-group
bluzky 8300ddc
wip trying fix radio group
bluzky 2b1ec67
add support for transforming items in a collection
selenil 4fc8e0f
remove todo comment
selenil 7f4ed00
parse collections using the data-option attribute
selenil b2bde49
Merge pull request #110 from selenil/feature/zag-collections
bluzky d02dd55
Update tooltip
bluzky 7c1a9f6
Update radio group to work with zagjs
bluzky 11e4d12
Update collapsible and select to match new zag component
bluzky 0d94231
Merge pull request #115 from bluzky/feature/accessibility-radio-group
bluzky a91a1ea
Update toggle group to match new component
bluzky fea64a7
Merge pull request #116 from bluzky/feature/accessibility-radio-group
bluzky bc82ae7
Merge remote-tracking branch 'origin/feature/accessibility-hook' into…
bluzky f5e0a67
Add zag for tooltip
bluzky 5231d7b
Merge pull request #117 from bluzky/feature/tooltip-accessibility
bluzky 14a0761
improve parts handling
selenil 2818e47
wip integrate zag for tabs
selenil 76605de
Merge pull request #118 from selenil/feature/improve-parts-handling
bluzky 8269bf4
implement event listeners system
selenil 11a437f
add show_tab function
selenil 61c3382
add validation to listeners
selenil 0d50a67
Update dropdown menu
bluzky 6fe1d4f
Merge pull request #125 from selenil/feature/zag-event-listeners
bluzky c94612e
add listeners support
selenil 0b610f7
add options support
selenil 4dbb207
improve documentation
selenil a7be91a
improve show_tab function
selenil 9855220
Merge pull request #119 from selenil/feature/improve-tabs
bluzky 3de961f
Implement zagjs for dropdown menu
bluzky 0e7360d
integrate zag with slider
selenil adceb25
improve documentation for slider component
selenil 25cdbe8
support bind zag api values to elements
selenil a91ed22
Merge pull request #132 from selenil/feature/improve-slider
bluzky 9341b6b
Merge pull request #131 from bluzky/feature/dropdown-menu-zag
bluzky fcd7200
Merge pull request #134 from selenil/feature/add-support-for-api-bind
bluzky ca3b346
add support for output in slider
selenil 0ebe6ed
integrate zag with progress component
selenil 70c5ce1
Merge pull request #138 from selenil/feature/add-support-for-output-t…
bluzky 2486fbb
Merge pull request #139 from selenil/feature/improve-progress
bluzky 678b25a
improve tooltip component
selenil 73d6833
fix typos
selenil 345c089
improve hover card component
selenil 7703c8b
add createZagHook function
selenil e594f35
install zag types package
selenil b82b8e5
modify salad.add task to work with the new zag setup
selenil 67b11cb
Merge pull request #145 from selenil/feature/avoid-copying-zag-hook
bluzky 52a18b1
improve accordion component
selenil 0f30e28
improve zag hook
selenil 18bd539
Merge pull request #147 from selenil/feature/improve-zag-hook
bluzky dbed2cd
Merge pull request #142 from selenil/feature/improve-multiple-components
bluzky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Error handling should clean up any partial installation when user aborts
Consider adding cleanup logic to remove any files or changes made before the abort