Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names #482

Merged
merged 50 commits into from
Dec 2, 2017
Merged

Add names #482

merged 50 commits into from
Dec 2, 2017

Conversation

CodeWritingCow
Copy link
Collaborator

Issue #460.

Use "cmn" for Chinese.
Add aliases and translation.
Merge "mitch" with "michael" because mitch is an alias for Michael.
Delete "mitch.json."
Add gender to file specs in readme.md. Add tests to validate each JSON's
gender value.
Resolve merge conflict by using main repo's version of JSON file.
Comment out tests for sex field. They are failing because names in
collection don't have that field. Issue bluzi#443
Tests run only on name files that contain a gender value. Issue bluzi#443
Update README.md to describe sex field as optional.
@CodeWritingCow CodeWritingCow changed the title Add two names Add names Nov 30, 2017
@TravisBuddy
Copy link

Travis tests has failed

Hey Gary Pang,
Please read the following log in order to understand why the tests failed.
It'll be awesome if you fix what's wrong and commit the changes.

npm test

> [email protected] test /home/travis/build/bluzi/name-db
> mocha



  name files
    1) should contain valid JSON
    2) should contain a lowercase name, same as the filename
    3) should not have duplicate names
    4) should have ISO-639-3 language codes
    5) should have correct structure

  Translations
    6) should be lowercase

  Sex
    7) should be "m", "f" or "u"
    8) should be lowercase


  0 passing (99ms)
  8 failing

  1) name files
       should contain valid JSON:
     Error: Error in name file "bruce.json": Invalid JSON file 
SyntaxError: Unexpected token } in JSON at position 172
      at Context.it (test/test.js:16:23)

  2) name files
       should contain a lowercase name, same as the filename:
     SyntaxError: Unexpected token } in JSON at position 172
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:24:31)

  3) name files
       should not have duplicate names:
     SyntaxError: Unexpected token } in JSON at position 172
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:35:31)

  4) name files
       should have ISO-639-3 language codes:
     SyntaxError: Unexpected token } in JSON at position 172
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:47:31)

  5) name files
       should have correct structure:
     Error: Error in name file "bruce.json":
SyntaxError: Unexpected token } in JSON at position 172
      at Context.it (test/test.js:106:23)

  6) Translations
       should be lowercase:
     SyntaxError: Unexpected token } in JSON at position 172
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:116:31)

  7) Sex
       should be "m", "f" or "u":
     SyntaxError: Unexpected token } in JSON at position 172
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:131:31)

  8) Sex
       should be lowercase:
     SyntaxError: Unexpected token } in JSON at position 172
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:145:31)



npm ERR! Test failed.  See above for more details.


@bluzi bluzi merged commit f65e63f into bluzi:master Dec 2, 2017
@bluzi
Copy link
Owner

bluzi commented Dec 2, 2017

Thanks @CodeWritingCow!
merged #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants