Add soft reset to chat list #7771
Open
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Scroll to top works, but I think we also want the listConvos query to refetch, right? That would need to be added to the listenSoftReset handler. Feed pages also truncate the infinite pagination cache first so that the query doesn't refetch all currently fetched pages, but that's probably less of an issue here.
|
I was thinking we don't need it to refetch since in theory it should be keep up to date via log polling |
|
Atm we poll every 60s, so could be a decent way get fresh data faster. I think we might as well add it here. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realised this was missing. Now works like other tabs
Test plan
Check that chat list scrolls to top when pressing the tab