-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Android app start faster by disabling JS bundle compression #7751
Make Android app start faster by disabling JS bundle compression #7751
Conversation
fixed |
Okay now it works, I fixed it! @gaearon do you guys have any TTI measurements in BlueSky? If yes, would be great if you could run those in release builds to see how much faster it got with my PR. I can't seem to be able to build the app in release. |
FYI @gaearon isn't working at Bluesky anymore: |
There's this: Line 860 in 40d05ac
You can get it to show up (and see it in logcat) by commenting out the "remove console" plugin in the prod Babel config.
Not sure if anything is broken, last time I tried |
Ok results are in: Current (mean of 10 runs): 805ms With change (mean of 10 runs): 773ms Improvement: 4% faster! That's not nothing, and this was on a Pixel 7A. I'd imagine that lower-powered phones might see more benefit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
* origin/main: Make Android app start faster by disabling JS bundle compression (#7751) Nightly source-language update Update tests Screen for searching user's posts (#7622) Add translations missed in last PR (#7748) 1.98 release: Pull latest from crowdin (#7746) [Instrumentation] Signin (#7742) Reenable router events (#7735) Nightly source-language update Bitdrift integration (#7728) Use effective filtering for feeds (#7736) Update PostInteractionSettingsDialog.tsx (#7726)
I haven't dug too deeply, but it looks like Lines 856 to 859 in 40d05ac
This sounds wrong to measure this specific improvement, since the performance gains already start a bit earlier than that; when Android starts to load the actual So if you measured 4% with this change, you only measured the mmap difference. The real improvements might be much bigger because we didn't measure the uncompression part of this whole thing. Anyways; it's faster now 😄 |
Seems like you’d want to measure the time from the first native app log to when this console log comes in. |
yep |
Disables compression for the
.bundle
resource files in the .apk.This makes the .apk a bit bigger, but improves startup time on Android - we measured a 400ms startup improvement (12%) in one of our apps.
Based on facebook/react-native#49449