-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add rule to resolve appeal on removed record #739
base: main
Are you sure you want to change the base?
Conversation
I'm nervous about the volume of requests we'll need to make to ozone: a request on every post deletion would be a lot. One way to reduce the volume would be to track appeals with a flag (using automod flagstore, based on redis), or a counter, and then do a check in the rule, and only update in those cases. This would, of course, only work for new appeals, not any backlog of appeals. I think we should basically always add mod actions for both accounts and records at the same time, so should have "resolve appeal" on account in addition to record in this PR, even if we only use the record version. I'm adding metadata population of appeal status to account metadata in a parallel PR, so we'll be able to check that at runtime if ever needed (eg, on account deletion). |
made a few changes following your recommendations and summarizing those below
questions at this point
|
I merged a bunch of refactors recently, so probably need to do a rebase or merge of this branch. |
No description provided.