break lexgen cborgen circular dependence #716
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OLD: When a new type comes in through lexgen, it cannot be compiled until after cborgen runs, but cborgen cannot run because the type cannot be compiled. So comment out a section, run cborgen, then uncomment the hidden code.
New:
make lexgen; make cborgen; make test
doneA type check that used to be done at compile time (which would fail) is now done in unit test code, which will pass after cborgen is run.
Requires forthcoming cbor-gen PR whyrusleeping/cbor-gen#102