Add linting rule to sort imports #3220
Merged
+3,563
−2,717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
msi/eslint-import
branch
2 times, most recently
from
643fc06 to
2944f2e
Compare
rafaelbsky
approved these changes
Jan 27, 2025
matthieusieben
force-pushed
the
msi/eslint-import
branch
2 times, most recently
from
04b6d5b to
bc2783d
Compare
matthieusieben
force-pushed
the
msi/eslint-import
branch
from
bc2783d to
5227bcf
Compare
matthieusieben
force-pushed
the
msi/eslint-import
branch
from
5227bcf to
b96f325
Compare
matthieusieben
added a commit
that referenced
this pull request
Feb 5, 2025
* Add linting rule to sort imports * remove spacing between import groups * changeset * changeset * prettier config fine tuning * forbid use of deprecated imports * tidy
matthieusieben
added a commit
that referenced
this pull request
Feb 5, 2025
* Add linting rule to sort imports * remove spacing between import groups * changeset * changeset * prettier config fine tuning * forbid use of deprecated imports * tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allow imports to be cleaned and sorted automatically on file save. It also adds an
engineproperty to NodeJS packages, ensuring proper compatibility for users of our packages.eslint-plugin-importrecommended rules to eslint configimport/orderrule to force consistent orderingeslint-plugin-nto make sure the features we use are consistent with the node version we support (>=18.7.0)engines: { node: ">=18.7.0" }to all packages meant for NodeJSNote
The supported NodeJS version is currently stated to be 18.0.0 but our code relies on features only available since 18.7.0. For this reason, the
enginesfields was updated to require NodeJS 18.7.0.Note
This PR adds an
enginefield to all NodeJS packages to ensure that users of the@atprotopackages can be notified by their package manager if their version of NodeJS might cause compatibility issues.