This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add prefix to scripts #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept a prefix to filter items by in scan_bucket/display_infected scripts. This is useful for users with large buckets who want to limit the time/cost of running these scripts.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--prefixargument toscan_bucket.pyanddisplay_infected.pyto limit the objects considered for each.For buckets with many (>100,000) the
scan_bucket.pyanddisplay_infected.pyscripts can incur long running times and non-negligible API costs to iterate an entire bucket. The--prefixoption passes a string to the ListObjectsV2 Prefix parameter which limits the objects to iterate and consider.Note: the long runtime/incurred costs issue remains present in the existing
--limitargument as it currently iterates the entire bucket before trimming the returned objects with a Python slice. I'm making these patches on a contract job so I don't have time to fix the pagination logic for this issue. Please advise if you'd like a separate issue to track.