Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Reduce warm lambda processing time and add SAM framework #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrba
Copy link

@andrba andrba commented Feb 12, 2020

Hi, we would like to propose the following changes to your repo:

Performance optimisation

clamscan loads virus databases each time it is executed. The actual scan operation takes an order of magnitude less time to complete.

4a06e795-09cd-437b-8891-2ebf3b1adb39

By starting ClamAV as a daemon and loading the virus databases only once, the execution time on warm lambdas improves drammatically:

Screen Shot 2020-02-12 at 4 26 53 pm

Deployment optimisation

Managing the deployments and AWS resources and policies manually is hard to track and prone to human error. Infrastructure as code greatly reduces the risk of resource management and traceability.

The deployment process described in the README.md is written in a template file that can be deployed via SAM.

This PR can be split into two if necessary.

Thank you for building this tool 🙏

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@sean-redmond sean-redmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems very sensible and useful PR

@sean-redmond sean-redmond mentioned this pull request Oct 19, 2020
@fbuchmeier
Copy link

fbuchmeier commented Oct 20, 2020

Hi folks,

I am currently testing this and the PR requires aws-sam-cli to be installed on the local machine (referenced in the Makefile).

So to make all work again with this PR, a

 pip install aws-sam-cli

Is required.

I tried to use a virtualenv/pipenv to install this, but this is not picked up by the Makefile.

Would it be a better option to include aws-sam-cli in the Docker Image and run it from there instead of relying on the existence on the build machine?

Regards,
Florian.

aleskovets pushed a commit to wiley/bucket-antivirus-function that referenced this pull request Apr 30, 2021
gchamon added a commit to waycarbon/bucket-antivirus-function that referenced this pull request Mar 1, 2023
must still verify if extra virus definitions get pulled form S3
from bluesentry#112
gchamon added a commit to waycarbon/bucket-antivirus-function that referenced this pull request Mar 1, 2023
must still verify if extra virus definitions get pulled form S3
from bluesentry#112
gchamon added a commit to waycarbon/bucket-antivirus-function that referenced this pull request Mar 1, 2023
must still verify if extra virus definitions get pulled form S3
from bluesentry#112
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants