test: Add port validation check after openURL#64
Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom Feb 24, 2025
Merged
Conversation
| auto port = AbstractLink::openUrl(CommandLine::self()->connectionString); | ||
| if (!port) { | ||
| std::cerr << "Failed to open communication link with device" << std::endl; | ||
| return -1; |
Member
There was a problem hiding this comment.
It would be nice to add a message inside the AbstractLink as well to print the reason
Contributor
Author
There was a problem hiding this comment.
Added message in different return paths from openURL plus the failed to open since the regex can be valid and still fails to open the port.
joaomariolago
force-pushed
the
add-unhandled-case-init-port
branch
from
3553ebf to
a605bd4
Compare
joaomariolago
force-pushed
the
add-unhandled-case-init-port
branch
from
a605bd4 to
c79056b
Compare
patrickelectric
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.