Skip to content

Commit

Permalink
rm comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rakita committed Jan 24, 2025
1 parent b7da808 commit ca87008
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 65 deletions.
55 changes: 0 additions & 55 deletions crates/optimism/src/api/inspect.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,6 @@ use revm::{
};
use std::vec::Vec;

// pub trait InspectOpEvm<CTX, INTR: InterpreterTypes>: ExecuteOpEvm {
// fn inspect<'a, 'b, INSP>(&'a mut self, tx: Self::Transaction, inspector: INSP) -> Self::Output
// where
// INSP: Inspector<&'a mut Self, INTR> + 'b,
// {
// self.set_tx(tx);
// self.inspect_previous(inspector)
// }

// /// Drawback if inspector overlives the context it will take the mutable reference
// /// of it and inspector needs to be dropped to release the mutable reference.
// fn inspect_previous<'a, 'b, INSP>(&'a mut self, inspector: INSP) -> Self::Output
// where
// INSP: Inspector<&'a mut Self, INTR> + 'b;
// }

impl<
BLOCK: Block,
TX: OpTxTrait,
Expand Down Expand Up @@ -135,45 +119,6 @@ where
.run(ctx)
}

// pub fn inspect_op<
// CTX: EthContext + InspectorCtx<IT = EthInterpreter> + JournalExtGetter,
// ERROR: EthError<CTX> + From<OpTransactionError> + IsTxError + FromStringError,
// FRAME: Frame<
// Context = CTX,
// Error = ERROR,
// FrameResult = FrameResult,
// FrameInit = FrameInput,
// FrameContext = FrameContext<
// OpPrecompileProvider<CTX, ERROR>,
// InspectorInstructionExecutor<EthInterpreter, CTX>,
// >,
// > + FrameInterpreterGetter<IT = EthInterpreter>,
// HANDLER: EthHandler<
// Context = CTX,
// Error = ERROR,
// Frame = FRAME,
// Precompiles = OpPrecompileProvider<CTX, ERROR>,
// HaltReason = OptimismHaltReason,
// > + Default,
// >(
// ctx: &mut CTX,
// ) -> Result<ResultAndState<OptimismHaltReason>, ERROR>
// where
// <CTX as CfgGetter>::Cfg: Cfg<Spec = OpSpec>,
// {
// //todo!();
// let mut evm = InspectorHandlerImpl::<
// CTX,
// ERROR,
// _,
// _,
// OpPrecompileProvider<CTX, ERROR>,
// EthInterpreter,
// >::new(HANDLER::default(), make_instruction_table());

// evm.run(ctx)
// }

pub fn inspect_op_commit<DB: Database + DatabaseCommit, CTX>(
ctx: &mut CTX,
) -> Result<
Expand Down
10 changes: 0 additions & 10 deletions crates/optimism/src/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -146,16 +146,6 @@ impl<BLOCK, TX: Transaction, CFG, DB: Database, JOURNAL: Journal<Database = DB>
}
}

// impl<BLOCK, TX: Transaction, CFG, DB: Database, JOURNAL: Journal<Database = DB> + JournalExt>
// InspectorContext for OpContext<BLOCK, TX, CFG, DB, JOURNAL>
// {
// type JournalExt = JOURNAL;

// fn journal_ext(&self) -> &Self::JournalExt {
// self.0.journal_ref()
// }
// }

impl<BLOCK, TX, CFG: Cfg, DB: Database, JOURNAL: Journal<Database = DB>> CfgGetter
for OpContext<BLOCK, TX, CFG, DB, JOURNAL>
{
Expand Down

0 comments on commit ca87008

Please sign in to comment.