Skip to content

Commit

Permalink
Feature calculators touchups (#1103)
Browse files Browse the repository at this point in the history
* Refactor query similarity

* Refactor linear trend timewise

* Refactor range_count

Changing variable names because this overloads the builtin python functions `max` and `min`.

Best to rename these to reduce any risk

* Avoid unneeded list comprehensions

Use list(dict.items())

* Switch if-elif-elif... to explicit mapping

* Remove unneeded else

* Explicit float 0.0 returns instead of int 0 returns

* Use f-strings

* Remove unused variable names with _

* Revert "Refactor range_count"

Reverts changes to the argument names for range count, see 3e3f936#r1915531370

* Respond to PR feedback

- Extract out centroid as a var
- Raise exception and add Literal type sig
- Switch order of branch evaluation

* Format higher-risk-f-strings

Related commit: 776ef3d
  • Loading branch information
Scott-Simmons authored Jan 25, 2025
1 parent 1aa689d commit fdfeaae
Showing 1 changed file with 115 additions and 120 deletions.
Loading

0 comments on commit fdfeaae

Please sign in to comment.