Restore Mesos 1.2 compatibility: Handle AllocationInfo within used resources #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following this change in Mesos 1.2 [1] we need to unset the allocation info of used resources. Otherwise the substraction to reduce the available oversubscribable resources will be come a no-op, which can lead to over- load. [1] apache/mesos@7497541
This is meant to simplify reasoning of the dynamic behaviour of the code and its associated logging messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this change in Mesos 1.2 [1] we need to unset the allocation info of used resources. Otherwise the subtraction to reduce the available oversubscribable resources will be come a no-op, which can lead to overload.
The second additional commit is mostly a cleanup. I was confused by the behaviour while reading the code and debugging.
[1] apache/mesos@7497541