Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glemu deadcode and macro purge #157

Merged
merged 1 commit into from Apr 29, 2023
Merged

glemu deadcode and macro purge #157

merged 1 commit into from Apr 29, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2020

Each line was removed, one by one, check that the compilation passed.
On Debian 10, with clang++ and some custum setup, all passes. CI will
check that all damn systems builds. It's the only thing it's setup for,
after all.
I will not apply ANY codestyle or doc patch on this, because it's just
a damn cleanup, not real changes.
To redo:

  • 1: apply cpp on your target
  • 2: n = 1
  • 3: until EOF
  • 4: remove line 1
  • 5: build
  • 6: if build failed, cancel 3
  • 7: n++
  • 8: goto 3

@ghost
Copy link
Author

ghost commented Jul 25, 2020

FYI: I don't intend to do any code style related change on this. It's something that a tool could have do, but I know none that is able to do that automatically, so I did it (partially, cpp helped a lot) manually.
It's damn annoying, but at least, the code is now minimal, and there are no longer macros for nothing.

Copy link
Member

@voidanix voidanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is a "just remove the macros mechanically" one, then we can clean this up later with real code changes.

#250 should take care of code-style changes down the road.

Each line was removed, one by one, check that the compilation passed.
On Debian 10, with clang++ and some custum setup, all passes. CI will
check that all damn systems builds. It's the only thing it's setup for,
after all.
I will *not* apply ANY codestyle or doc patch on this, because it's just
a damn cleanup, not real changes.
To redo:
* 1: apply `cpp` on your target
* 2: n = 1
* 3: until EOF
* 4: remove line 1
* 5: build
* 6: if build failed, cancel 3
* 7: n++
* 8: goto 3
@voidanix voidanix merged commit 3bf5793 into blue-nebula:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant