Merge branch 'snowflake' into bloomberg-snowflake

.mvn/jvm.config

@@ -9,3 +9,4 @@
 --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
 --add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED
 --add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED
+--add-opens=java.base/java.nio=ALL-UNNAMED

core/trino-server/src/main/provisio/trino.xml

@@ -289,6 +289,12 @@
             <unpack />
         </artifact>
     </artifactSet>
+
+    <artifactSet to="plugin/snowflake">
+        <artifact id="${project.groupId}:trino-snowflake:zip:${project.version}">
+            <unpack />
+        </artifact>
+    </artifactSet>  
 
     <artifactSet to="plugin/sqlserver">
         <artifact id="${project.groupId}:trino-sqlserver:zip:${project.version}">

docs/src/main/sphinx/connector.rst

@@ -0,0 +1,47 @@
+**********
+Connectors
+**********
+
+This chapter describes the connectors available in Trino to access data
+from different data sources.
+
+.. toctree::
+    :maxdepth: 1
+
+    Accumulo        <connector/accumulo>
+    Atop            <connector/atop>
+    BigQuery        <connector/bigquery>
+    Black Hole      <connector/blackhole>
+    Cassandra       <connector/cassandra>
+    ClickHouse      <connector/clickhouse>
+    Delta Lake      <connector/delta-lake>
+    Druid           <connector/druid>
+    Elasticsearch   <connector/elasticsearch>
+    Google Sheets   <connector/googlesheets>
+    Hive            <connector/hive>
+    Hudi            <connector/hudi>
+    Iceberg         <connector/iceberg>
+    Ignite          <connector/ignite>
+    JMX             <connector/jmx>
+    Kafka           <connector/kafka>
+    Kinesis         <connector/kinesis>
+    Kudu            <connector/kudu>
+    Local File      <connector/localfile>
+    MariaDB         <connector/mariadb>
+    Memory          <connector/memory>
+    MongoDB         <connector/mongodb>
+    MySQL           <connector/mysql>
+    Oracle          <connector/oracle>
+    Phoenix         <connector/phoenix>
+    Pinot           <connector/pinot>
+    PostgreSQL      <connector/postgresql>
+    Prometheus      <connector/prometheus>
+    Redis           <connector/redis>
+    Redshift        <connector/redshift>
+    SingleStore     <connector/memsql>
+    Snowflake       <connector/snowflake>
+    SQL Server      <connector/sqlserver>
+    System          <connector/system>
+    Thrift          <connector/thrift>
+    TPCDS           <connector/tpcds>
+    TPCH            <connector/tpch>

docs/src/main/sphinx/connector/snowflake.rst

@@ -0,0 +1,107 @@
+===================
+Snowflake connector
+===================
+
+.. raw:: html
+
+  <img src="../_static/img/snowflake.png" class="connector-logo">
+
+The Snowflake connector allows querying and creating tables in an
+external `Snowflake <https://www.snowflake.com/>`_ account. This can be used to join data between
+different systems like Snowflake and Hive, or between two different
+Snowflake accounts.
+
+Configuration
+-------------
+
+To configure the Snowflake connector, create a catalog properties file
+in ``etc/catalog`` named, for example, ``example.properties``, to
+mount the Snowflake connector as the ``snowflake`` catalog.
+Create the file with the following contents, replacing the
+connection properties as appropriate for your setup:
+
+.. code-block:: none
+
+    connector.name=snowflake
+    connection-url=jdbc:snowflake://<account>.snowflakecomputing.com
+    connection-user=root
+    connection-password=secret
+    snowflake.account=account
+    snowflake.database=database
+    snowflake.role=role
+    snowflake.warehouse=warehouse
+
+Arrow serialization support
+^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+This is an experimental feature which introduces support for using Apache Arrow
+as the serialization format when reading from Snowflake.  Please note there are
+a few caveats:
+
+* Using Apache Arrow serialization is disabled by default. In order to enable
+  it,  add ``--add-opens=java.base/java.nio=ALL-UNNAMED`` to the Trino
+  :ref:`jvm-config`.
+
+
+Multiple Snowflake databases or accounts
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+The Snowflake connector can only access a single database within
+a Snowflake account. Thus, if you have multiple Snowflake databases,
+or want to connect to multiple Snowflake accounts, you must configure
+multiple instances of the Snowflake connector.
+
+.. snowflake-type-mapping:
+
+Type mapping
+------------
+
+Trino supports the following Snowflake data types:
+
+==================================  ===============================
+Snowflake Type                      Trino Type
+==================================  ===============================
+``boolean``                         ``boolean``
+``tinyint``                         ``bigint``
+``smallint``                        ``bigint``
+``byteint``                         ``bigint``
+``int``                             ``bigint``
+``integer``                         ``bigint``
+``bigint``                          ``bigint``
+``float``                           ``real``
+``real``                            ``real``
+``double``                          ``double``
+``decimal``                         ``decimal(P,S)``
+``varchar(n)``                      ``varchar(n)``
+``char(n)``                         ``varchar(n)``
+``binary(n)``                       ``varbinary``
+``varbinary``                       ``varbinary``
+``date``                            ``date``
+``time``                            ``time``
+``timestampntz``                    ``timestamp``
+``timestamptz``                     ``timestampTZ``
+``timestampltz``                    ``timestampTZ``
+==================================  ===============================
+
+Complete list of `Snowflake data types
+<https://docs.snowflake.com/en/sql-reference/intro-summary-data-types.html>`_.
+
+.. _snowflake-sql-support:
+
+SQL support
+-----------
+
+The connector provides read access and write access to data and metadata in
+a Snowflake database.  In addition to the :ref:`globally available
+<sql-globally-available>` and :ref:`read operation <sql-read-operations>`
+statements, the connector supports the following features:
+
+* :doc:`/sql/insert`
+* :doc:`/sql/delete`
+* :doc:`/sql/truncate`
+* :doc:`/sql/create-table`
+* :doc:`/sql/create-table-as`
+* :doc:`/sql/drop-table`
+* :doc:`/sql/alter-table`
+* :doc:`/sql/create-schema`
+* :doc:`/sql/drop-schema`

plugin/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestSnowflakeConnectorTest.java

@@ -35,4 +35,4 @@ protected SqlExecutor onRemoteDatabase()
     {
         return server::execute;
     }
-}
+}

plugin/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestSnowflakeTypeMapping.java

@@ -408,4 +408,4 @@ private static boolean isGap(ZoneId zone, LocalDate date)
     {
         return zone.getRules().getValidOffsets(date.atStartOfDay()).isEmpty();
     }
-}
+}

plugin/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestingSnowflakeServer.java

@@ -74,4 +74,4 @@ public void close()
     {
         execute("DROP SCHEMA IF EXISTS tpch");
     }
-}
+}