Fix decoding Python 3.13 stacks without symbols #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
fix_decoding_3.13_stacks_without_symbols
branch
from
ed51a42
to
d10e300
Compare
The eager `isValid` check that we implemented originally fails when symbols aren't available, as we're unable to look up `PyCode_Type` to compare the type of `f_executable` against it. Instead, let's treat every `f_executable` as though it's a `PyCode_Type` without checking in advance. If it's not able to be interpreted as a `PyCode_Type`, we'll expect a `RemoteMemCopyError` from chasing an invalid pointer at some point, and can handle that the way that we have been handling `!isValid`. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
fix_decoding_3.13_stacks_without_symbols
branch
from
d10e300
to
3db2f8e
Compare
|
Adding "skip news" since this fixes a bug that never made it into a release. |
pablogsal
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eager
isValidcheck that we implemented originally fails when symbols aren't available, as we're unable to look upPyCode_Typeto compare the type off_executableagainst it.Instead, let's treat every
f_executableas though it's aPyCode_Typewithout checking in advance. If it's not able to be interpreted as aPyCode_Type, we'll expect aRemoteMemCopyErrorfrom chasing an invalid pointer at some point, and can handle that the way that we have been handling!isValid.Closes #205
I tested this manually and confirmed that it does allow us to successfully decode a Python 3.13 core's Python stack even without the correct executable being available. There's no automated test added here, but in fairness the old
isValidbehavior that's being replaced was also not covered by any automated test.