RDISCROWD-7659 password logic in ProjectCommonForm

[n00rsy]

Issue number of the reported bug or feature request: RDISCROWD-7659

Refactor #972 after code review.

[coveralls]

Pull Request Test Coverage Report for Build 11018626401

Details

• 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.005%) to 94.01%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pybossa/forms/forms.py	5	6	83.33%

Totals
Change from base Build 11016071335:	0.005%
Covered Lines:	17327
Relevant Lines:	18431

---

💛 - Coveralls

[kbecker42]

Do we want to keep def __init__ on line 107-108 and 112-113?

The original PR included __init__ and super(ProjectForm...), but here it is being removed. It may need to be added back here so that the original is intact.

The only difference was adding self.password.validators with CheckPasswordStrength which can reside in ProjectCommonForm.

[n00rsy]

1. Constructor on lines 107-108:
   We removed the constructor in lines 107-108 and declared a new one starting on line 87 for ProjectCommonForm.

2. Constructor on lines 112-113
   Removing the __init__ function from ProjectForm will make it default to it's parent class's constructor, ProjectCommonForm - exactly what we want.

See https://stackoverflow.com/questions/39488875/parent-constructor-called-by-default