update test

bloomberg · Oct 10, 2024 · 66e2677 · 66e2677
1 parent 0b025cf
commit 66e2677
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pybossa/util.py b/pybossa/util.py
@@ -371,7 +371,7 @@ def datetime_filter(source, fmt):
 def validate_ownership_id(o_id):
     ownership_id_title = current_app.config.get('OWNERSHIP_ID_TITLE', 'Ownership ID')
     if o_id == None or len(o_id) == 0:
-        return True
+        return
     if not (o_id.isnumeric() and len(o_id) <= 20):
         raise ValueError(f"{ownership_id_title} must be numeric and less than 20 characters. Got: {o_id}")
 

diff --git a/test/test_util.py b/test/test_util.py
@@ -1909,8 +1909,8 @@ def test_validate_ownership_id(self):
         ownership_id = ""
         util.validate_ownership_id(ownership_id)
 
-        # ownership_id too long
-        ownership_id = "12341234123412341234"
+        # ownership_id too long (> 20 chars)
+        ownership_id = "123412341234123412341234"
         assert_raises(ValueError, util.validate_ownership_id, ownership_id)
 
         # ownership_id not numeric