Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement simple mocking framework and test ntcr::StreamSocket shutdown sequence during connection phase using whitebox testing approach #142

Merged
merged 60 commits into from
Apr 22, 2024

Conversation

smtrfnv
Copy link
Contributor

@smtrfnv smtrfnv commented Apr 10, 2024

This PR brings an in-house lightweight framework to mock classes. The interface was inspired by existing mocking frameworks, though its current functionality is far behind from existing solutions. The main pro is that we do not introduce a dependancy to any new library.

This framework is used to test ntcr::StreamSocket shutdown sequence during connection phase.

@smtrfnv smtrfnv marked this pull request as ready for review April 15, 2024 13:35
Copy link
Contributor

@mattrm456 mattrm456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge. I think we might run into potential problems with macros with simple, undecorated, all-uppercase names using like ONCE, TIMES, TO, etc. but let's tackle that when we notice that we are colliding with the preprocessor. And more generally, let's continue to integrate tests based upon this machinery to see where else we need to take this testing infrastructure.

@mattrm456 mattrm456 merged commit 33fd060 into bloomberg:main Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants