Optimize comdb2_files access #4745
Draft
+467
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
suggested changes
Oct 2, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 7/580 tests failed ⚠.
The first 10 failing tests are:
writes_remsql_names_fdbpushredirect_generated [setup failure]
blob2 [setup failure]
basic_snapshot_generated [setup failure]
truncatesc
timepart_trunc_serialsc_generated
snap_ha_retry_newsi_generated
auth
Signed-off-by: Morgan Douglas <[email protected]>
morgando
force-pushed
the
comdb2_files_eq
branch
from
bfbd2af
to
7b1f23b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more indices for
comdb2_filesand implements basic index selection protocol.Not safe to run a query with OR'd indexed constraints if we intend to use the results to start a db clone: since the indexed constraints will be processed separately we can't guarantee that the logfiles will be read last.