Replace is_incomplete_type with is_complete_type #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: delimbetov <[email protected]>
Signed-off-by: delimbetov <[email protected]>
|
Looks great - unfortunately, I threw a bunch of merge conflicts at you :( Basically every |
Signed-off-by: delimbetov <[email protected]> # Conflicts: # libcxx/test/std/experimental/reflection/define-class.pass.cpp # libcxx/test/std/experimental/reflection/entity-classification.pass.cpp # libcxx/test/std/experimental/reflection/p2996-ex-compile-time-ticket-counter.pass.cpp # libcxx/test/std/experimental/reflection/substitute.pass.cpp
Signed-off-by: delimbetov <[email protected]>
@katzdm fixed : ) |
katzdm
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In P2996r5 is_incomplete_type was removed in favour of is_complete_type.
This PR implements the change.
Testing performed
There were tests already, I just had to make them work with the new interface.
Most of the changes are conversions of
is_incomplete_typeto! is_complete_type.However for the reflections of non-types, both old and new version of the function returns 'false'.