Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh flex & stax golden snapshots #22

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

sponomarev
Copy link

No description provided.

@0xMMBD
Copy link
Member

0xMMBD commented Sep 11, 2024

Hello @sponomarev It looks like the tests are now failing with some timeout error
https://github.com/blockydevs/app-solana/actions/runs/10807568213/job/29978742195?pr=22

=========================== short test summary info ============================
FAILED tests/python/test_solana.py::TestOffchainMessageSigning::test_ledger_sign_offchain_message_ascii_expert_ok[flex] - TimeoutError: Timeout waiting for screen change
FAILED tests/python/test_solana.py::TestOffchainMessageSigning::test_ledger_sign_offchain_message_ascii_expert_refused[flex] - TimeoutError: Timeout waiting for screen change
FAILED tests/python/test_solana.py::TestOffchainMessageSigning::test_ledger_sign_offchain_message_utf8_expert_ok[flex] - TimeoutError: Timeout waiting for screen change
FAILED tests/python/test_solana.py::TestOffchainMessageSigning::test_ledger_sign_offchain_message_utf8_expert_refused[flex] - TimeoutError: Timeout waiting for screen change
========================= 4 failed, 9 passed in 36.34s =========================

Isn't that caused on this type of screen where you need to hold to sign?
LedgerHQ#90 (comment)
image

@sponomarev
Copy link
Author

Expert mode setting has been moved to another screen and the test suite was not able to click on the screen 🤦

@0xMMBD 0xMMBD merged commit a567bc7 into blockydevs:develop Sep 11, 2024
118 of 120 checks passed
@sponomarev sponomarev deleted the chore/flex-stax-snapshots branch September 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants