reimburse: ensure ata, ensure not transferred in last 10 txs, transfer #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microwavedcola1
force-pushed
the
mc/reimburse
branch
from
b4c9911 to
510803c
Compare
microwavedcola1
commented
Oct 13, 2022
src/scripts/reimburse.ts
Outdated
| const sigs = await connection.getConfirmedSignaturesForAddress2( | ||
| destinationAta, | ||
| ); | ||
| for (const sig of sigs.slice(0, 10)) { |
There was a problem hiding this comment.
are past 10 good enough?
microwavedcola1
force-pushed
the
mc/reimburse
branch
3 times, most recently
from
4fef71d to
0e0ff48
Compare
Signed-off-by: microwavedcola1 <[email protected]>
microwavedcola1
force-pushed
the
mc/reimburse
branch
from
0e0ff48 to
f816631
Compare
ckamm
reviewed
Oct 13, 2022
| const meta = await connection.getParsedTransaction( | ||
| sig.signature, | ||
| 'confirmed', | ||
| ); |
There was a problem hiding this comment.
Only looking at a limited set of tx in the past sounds unsafe. I don't know how to do this well though, maybe we store which addresses we've tried to deal with and if we need to rerun we check all tx back to a certain start-slot for our source address and filter out candidates that way?
| ); | ||
|
|
||
| // Send and confirm | ||
| const sig = await sendAndConfirmTransaction(connection, tx, [PAYER], { |
There was a problem hiding this comment.
sending lots and lots of tx is something that's done well in the solana program deploy cli tool. Honestly, I'd borrow that. They know how to send and resend thousands of tx safely and in a timely manner.
Signed-off-by: microwavedcola1 <[email protected]>
microwavedcola1
force-pushed
the
mc/reimburse
branch
from
52880e5 to
d4a4f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: microwavedcola1 [email protected]