-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker-compose to use pre-built image #1244
base: main
Are you sure you want to change the base?
Conversation
Update `smart-contract-verifier/docker-compose.yml` to use pre-built Docker image from registry. * Change the `image` field to `ghcr.io/blockscout/smart-contract-verifier:main` * Remove the `build` section * Ensure the `ports` and `environment` sections remain unchanged --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/blockscout/blockscout-rs?shareId=XXXX-XXXX-XXXX-XXXX).
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request modifies the Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
smart-contract-verifier/docker-compose.yml
(1 hunks)
🔇 Additional comments (1)
smart-contract-verifier/docker-compose.yml (1)
5-18
: Configuration preserved correctly.The essential service configuration has been maintained:
- Port mappings for both service endpoints
- Environment variable and configuration file handling
- Volume mounts for compilers persistence
Thank you.
Sent from Yahoo Mail for iPhone
On Tuesday, February 18, 2025, 2:27 PM, coderabbitai[bot] ***@***.***> wrote:
@coderabbitai[bot] commented on this pull request.
In smart-contract-verifier/docker-compose.yml:
@@ -1,11 +1,7 @@
version: "3"
services:
smart-contract-verifier:
- ## you can build an image locally, or use pre-built images from registry
-# image: ghcr.io/blockscout/smart-contract-verifier:main
- build:
- context: .
- dockerfile: ./Dockerfile
+ image: ghcr.io/blockscout/smart-contract-verifier:main
🧩 Analysis chain
@Nichebiche I'll help you find the available version tags for the image. I've attempted to fetch them above. Once we have the list of available tags, you can choose a specific version to use in place of main. Would you like me to help you identify the most recent stable version tag?
🏁 Script executed:
#!/bin/bash
# Try to fetch tags using GitHub CLI which handles authentication
gh api \
-H "Accept: application/vnd.github.v3+json" \
/orgs/blockscout/packages/container/smart-contract-verifier/versions \
--jq '.[].metadata.container.tags[]' \
2>/dev/null || echo "Unable to fetch tags. Please check the package repository manually."
Length of output: 175
@Nichebiche I see that only main and build-cache tags are currently available for the container image. This is unusual, as typically there should be version-specific tags. I'm checking the repository releases to see if we can find appropriate version tags to use. In the meantime, would you be able to clarify:
- Is this for a production environment?
- Are there specific release tags that should be used for this container?
This will help us ensure we're using the most appropriate and stable version for your needs.
🏁 Script executed:
#!/bin/bash
# Check repository releases
gh api \
-H "Accept: application/vnd.github.v3+json" \
/repos/blockscout/blockscout-rs/releases \
--jq '.[].tag_name' \
2>/dev/null || echo "Unable to fetch releases"
Length of output: 651
@Nichebiche I found that the latest stable version for the smart-contract-verifier is v1.9.0. Let's update the image tag to use this specific version:
image: ghcr.io/blockscout/smart-contract-verifier:v1.9.0
This will provide better stability and reproducibility compared to using the main tag. Would you like to make this change?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Tip For best results, initiate chat on the files or code changes. @Nichebiche You're welcome! Just to confirm - would you like me to suggest the change to use the specific version tag (`・ω・´)ゞ |
Yes please make the change
Sent from Yahoo Mail for iPhone
On Tuesday, February 18, 2025, 2:28 PM, coderabbitai[bot] ***@***.***> wrote:
Tip
For best results, initiate chat on the files or code changes.
@Nichebiche You're welcome! Just to confirm - would you like me to suggest the change to use the specific version tag v1.9.0 instead of main? This would help ensure better stability and reproducibility.
(`・ω・´)ゞ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
coderabbitai[bot] left a comment (blockscout/blockscout-rs#1244)
Tip
For best results, initiate chat on the files or code changes.
@Nichebiche You're welcome! Just to confirm - would you like me to suggest the change to use the specific version tag v1.9.0 instead of main? This would help ensure better stability and reproducibility.
(`・ω・´)ゞ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Update
smart-contract-verifier/docker-compose.yml
to use pre-built Docker image from registry.image
field toghcr.io/blockscout/smart-contract-verifier:main
build
sectionports
andenvironment
sections remain unchangedFor more details, open the Copilot Workspace session.
Summary by CodeRabbit