Added missing AddressService api call #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nemo83 Looks like integration tests are still pointing to LEGACY TESTNET URL which needs to be changed. But tests with PREPROD makes sense. |
|
Just tried to use preprod and no tests pass 😭 I wouldn't want this to block merging this PR. Thoughts? |
|
@nemo83, Let's just add a test class with preprod data for this api. But we will ignore the test run result for now. @mmahut Can you please help to update the Project Id from Legacy testnet to Preprod for this repo ? Please use the same key as legacy testnet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
there's an interesting api call on the blockfrost api for addresses that was missing in the java lib.
I've implemented it and seems to be working.
Just not sure how to write a reliable test. Do I need to setup something on preview/preprod and test w/ a specific project id?
Thanks