Repository navigation
Conversation
Upstream endoflife.date only publishes major cycles for amazon-aurora-mysql, so every 3.x cluster classified GREEN against the cycle-3 date of 2028-04-30 even though e.g. 3.04 ends standard support on 2026-10-31 and 3.05-3.07 ended on 2025-08-31. Add per-minor cycles from the AWS release calendar, refresh the manifest review, and cover the version->cycle mapping with a provider-level test.
Kiran01bm
marked this pull request as ready for review
October 1, 2026 00:29
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
rileyepruitt
approved these changes
Oct 1, 2026
rileyepruitt
left a comment
There was a problem hiding this comment.
🤖 Reviewed by Riley’s AI agent against the PR description at 6534bf8. No P0 or P1 findings. Verified provider-to-policy classification and passed the full race-enabled test suite plus override go vet. Production use of the override endpoint remains unverified, as noted in the PR description.
bakayolo
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Aurora MySQL 3.x clusters currently classify GREEN because the
amazon-aurora-mysqloverride only carries major cycles, and upstream endoflife.date publishes the same major-only data (cycle3→ EOL 2028-04-30). AWS ends standard support per minor version, so3.04.2prefix-matches cycle3and is never flagged even though 3.04 ends standard support on 2026-10-31.deploy/endoflife-override/api/amazon-aurora-mysql.json: add per-minor cycles from the AWS release calendar: 3.04 (LTS, 2026-10-31), 3.05/3.06/3.07 (2025-08-31, from an archived copy of the calendar), 3.08/3.09 (2026-08-31), 3.10 (LTS, 2028-04-30), 3.11/3.12/3.13, 8.4.7/8.4.8, 2.11/2.12 (extended support to 2029-06-30). Cycle2extended support corrected to 2029-06-30 per the current calendar.deploy/endoflife-override/manifest.json: update the aurora entry's reason andsource_url(the old "pending upstream inclusion" reason is stale — upstream merged, but major-only), bumpreviewed_on/review_due_on.deploy/endoflife-override/aurora_mysql_test.go: new test that loads the override through the realendoflife.NewProviderand asserts the version→cycle mapping and dates (3.04.2, 3.06.0, 3.08.2, 3.10.1, 8.4.7, 2.11.5, fallback 3.99.0→3). It fails against the previous JSON.deploy/endoflife-override/manifest_test.go: date-sensitive cases now derive from the manifest'sreviewed_on/review_due_oninstead of hard-coded 2026-08 dates, so future review bumps don't break them.No provider or policy code changes; the longest-prefix cycle match in
pkg/eol/endoflifealready resolves3.04.2 → 3.04once the cycle exists.Related issues
amazon-aurora-mysqlproduct (following theamazon-rds-mysqlmodel: major cycles kept, one cycle per minor witheoas= minor end of standard support,eol/eoesinherited from the major, plus arelease_tablemethod that scrapes the minor-version calendar). Once that merges, this override can be removed and the manifest entry dropped. Note upstream expresses the minor date aseoas/support, noteol, so the adapter will surface it asstandardEndrather than the terminal date — worth checking the policy weighting before removing the override.extraContainers: []andEOL_BASE_URLdefaults tohttps://endoflife.date/api. Does the deployed worker run the override nginx sidecar? If not, this file is inert in production and the same fix has to be applied where the deployment values live.DescribeDBEngineVersions/DescribeDBMajorEngineVersionsso Aurora lifecycle dates are not hand-maintained.Testing performed
go test -race ./deploy/endoflife-override/ ./pkg/eol/... ./pkg/policy/...— pass.go vet ./deploy/endoflife-override/,gofmt -l deploy/— clean.make lintfails on cleanmainwithcan't load config: 'output.formats' expected a map, got 'slice'(golangci-lint config/version mismatch); not addressed here.