Repository navigation
Conversation
endoflife.date#9534 (amazon-aurora-mysql) merged upstream on 2026-08-23 and the live API now serves the product, so the "shim while the PR is open" wording in README.md and ARCHITECTURE.md no longer holds.
…ge check endoflife.date now serves every cycle both overrides carried (#9534 merged 2026-08-23, #9919 merged 2026-04-18) and the runtime adapter derives the same lifecycle state from upstream as from the local files, so the shim was only masking newer upstream dates. Nothing detected that: the validator only checks manifest shape. The new integration-tagged check fails when upstream fully covers an override, and the manifest tests now run against synthetic testdata instead of the live override files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retire the
amazon-aurora-mysqlandamazon-opensearchendoflife.date overrides now that upstream serves them, and add the check that should have flagged this.Why
endoflife.date#9534 (Amazon Aurora MySQL) merged 2026-08-23 and endoflife.date#9919 (OpenSearch 3.3/3.5) merged 2026-04-18. Upstream now carries every cycle both overrides held, and both entries passed their
review_due_on(2026-09-04). Nothing in the repo could tell us: the manifest validator checks shape and dates, not whether upstream has caught up, and the manifest tests were pinned to the two live override files. Meanwhile the shim was serving stale data — upstream has since moved Aurora MySQL 2 extended support to 2029-06-30, added Aurora MySQL 8.4, and replaced the OpenSearch 1.x/2.x booleaneol/extendedSupportflags with real dates.What
deploy/endoflife-override/api/{amazon-aurora-mysql,amazon-opensearch}.json;manifest.jsonis nowoverrides: [].api/.gitkeepkeeps the directory for the docker-compose bind mount and the validator.upstream.go:checkUpstreamCoveragecompares each manifest override againstendoflife.Clientcycles; a 404 upstream means "still needed", full coverage means retirable. Unit-tested withMockClient;upstream_integration_test.go(-tags=integration) runs it against the live API and fails naming retirable products.manifest_test.gonow copies synthetic fixtures fromtestdata/valid/instead of the live overrides, and gains a "no overrides" case.values.yamlexample no longer names the deleted files.Verified: ran the runtime
StandardSchemaAdapterover both override files and the upstream payloads — all 19 shared cycles derive the same state (SUPPORTED/EXTENDED/EOL), only dates move to upstream's newer values. The new integration test fails onmain's manifest (both products retirable) and passes after removal. With the override files gone, the nginx shim serves both products withX-Version-Guard-EOL-Source: endoflife_date, unknown products still 404, and a local file still wins when present. Lint clean on golangci-lint v1.64.8 with and without the integration tag.Before / after
References