Skip to content

Add per-agent MCP toolset configuration to agent setup#279

Merged
wpfleger96 merged 3 commits intomainfrom
sprout-ux/toolsets-ui
Apr 10, 2026
Merged

Add per-agent MCP toolset configuration to agent setup#279
wpfleger96 merged 3 commits intomainfrom
sprout-ux/toolsets-ui

Conversation

@wpfleger96
Copy link
Copy Markdown
Collaborator

@wpfleger96 wpfleger96 commented Apr 8, 2026

This PR adds a mcpToolsets field to the agent setup UI, replacing the global SPROUT_TOOLSETS env var as the only way to enable toolsets like canvas, channel_admin, and dms.

Previously, toolset selection required setting SPROUT_TOOLSETS in the shell before launching the desktop app — no way to scope it per-agent, making multi-agent setups with different tool scopes impractical.

  • Add mcp_toolsets: Option<String> to ManagedAgentRecord, CreateManagedAgentRequest, and UpdateManagedAgentRequest in types.rs
  • In runtime.rs, forward mcp_toolsets as SPROUT_TOOLSETS to the spawned MCP subprocess; remove it when None to prevent inheriting a stale ambient env var
  • Add a comma-separated mcpToolsets text input in the Advanced Setup section of CreateAgentDialogSections.tsx with a help line listing all available toolset names

Post-merge tasks

@wpfleger96 wpfleger96 requested a review from wesbillman as a code owner April 8, 2026 22:29
@wesbillman
Copy link
Copy Markdown
Collaborator

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 149546516f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@wpfleger96 wpfleger96 force-pushed the sprout-ux/toolsets-ui branch from 1495465 to b2cfbc5 Compare April 9, 2026 20:12
Toolsets like canvas, channel_admin, dms, and workflow_admin could only
be enabled by setting SPROUT_TOOLSETS in the shell environment before
launching the desktop app — with no way to configure them per-agent in
the UI. This made multi-agent setups where different agents need
different tool scopes impractical.

Adds an mcp_toolsets field to ManagedAgentRecord, CreateManagedAgentRequest,
and UpdateManagedAgentRequest. The runtime reads this field and forwards
it as SPROUT_TOOLSETS to the spawned MCP subprocess, overriding (or
removing) any ambient env var. A comma-separated text input appears in
the Advanced Setup section of the create-agent dialog, placed next to
the MCP command field, with a help line listing the available toolset
names.
Backticks in JSX strings render as visible characters, not as
inline code formatting.
createManagedAgent() built the input object explicitly but omitted
mcpToolsets, so the value collected in the dialog was silently dropped.
Per-agent toolset configuration did nothing at creation time.
@wpfleger96 wpfleger96 force-pushed the sprout-ux/toolsets-ui branch from b2cfbc5 to b4c9ab2 Compare April 10, 2026 16:34
@wpfleger96
Copy link
Copy Markdown
Collaborator Author

image

@wpfleger96 wpfleger96 merged commit d0970d6 into main Apr 10, 2026
9 checks passed
@wpfleger96 wpfleger96 deleted the sprout-ux/toolsets-ui branch April 10, 2026 17:42
tlongwell-block added a commit that referenced this pull request Apr 11, 2026
…ona-migration

* origin/main:
  feat(desktop): add Pulse social notes surface (#296)
  Fix flaky desktop smoke tests (#294)
  Add agent lifecycle controls to channel members sidebar (#291)
  Update nest_agents.md tagging info (#292)
  feat: add Sprout nest — persistent agent workspace at ~/.sprout (#290)
  Fix auth and SSRF vulns (#261)
  Add per-agent MCP toolset configuration to agent setup (#279)
  feat(desktop): team & persona import/edit flows (#288)
  Remove menu item subtitles and fix persona card overflow (#289)
  feat: Phase 1 video upload support (Blossom-compliant-ish) (#285)
  Add inline subtitles to menu items and field descriptions (#276)
  Improve ephemeral channel affordances and hide archived sidebar rows (#286)
  Fix @mention search to use word-boundary prefix matching (#278)
  Allow bot owners to remove their agents from any channel (#284)
  [codex] Polish agent selectors and settings layout (#283)

# Conflicts:
#	desktop/scripts/check-file-sizes.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants