Conversation
Per Dependabot, the old version has several vulnerabilities. Upgrade to the latest. This also triggered a new error for an existing bug in the code (passing a non-constant format string to an error formatter), so I fixed that too.
jemiahw
requested review from
allanliu,
Copilot,
pamelayin,
qian-squareup and
zyin-squareup
There was a problem hiding this comment.
Pull request overview
This pull request upgrades crypto-related dependencies to address security vulnerabilities identified by Dependabot and fixes a format string bug that was revealed by the upgraded Go tooling.
Changes:
- Upgraded Go from 1.23.0 to 1.24.0 and removed explicit toolchain directive
- Updated golang.org/x dependencies (crypto, net, sync, text, tools, mod) to newer versions
- Fixed format string issue in error handler for WebSocket upgrade failures
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates Go version to 1.24.0 and upgrades golang.org/x dependencies to address security vulnerabilities |
| go.sum | Updates checksums for upgraded dependencies, consistent with go.mod changes |
| api/api_gomux.go | Fixes format string bug in ErrInternal.New() call by adding "%s" format specifier |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qian-squareup
approved these changes
Feb 25, 2026
zyin-squareup
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Dependabot, the old version has several vulnerabilities. Upgrade to the latest.
This also triggered a new error for an existing bug in the code (passing a non-constant format string to an error formatter), so I fixed that too.