fix: handle stale MinIO test container#251
Merged
alecthomas merged 2 commits intomainfrom Apr 12, 2026
Merged
Conversation
When the MinIO test container crashes, `docker run` fails with "already in use" but the old code silently ignored this, causing waitForReady to timeout. Now we unconditionally `docker rm -f` before starting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When the container exists but is stopped, use `docker start` to restart it rather than `docker rm -f` which could race with other test packages using the same container in CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alecthomas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the MinIO test container exits/crashes,
docker runfails with"already in use" but the old code silently ignored this, causing
waitForReadyto timeout after 30s.Fix: when
docker runhits a name conflict, restart the existingcontainer with
docker startinstead of removing it. This avoidsracing with other test packages that may already be using the
container in parallel CI runs.