Skip to content

fix(ci): bump golangci-lint to v1.64.8 for Go 1.24 support#5

Merged
revied merged 5 commits intoblock:mainfrom
revied:fix/golangci-lint-version
Apr 13, 2026
Merged

fix(ci): bump golangci-lint to v1.64.8 for Go 1.24 support#5
revied merged 5 commits intoblock:mainfrom
revied:fix/golangci-lint-version

Conversation

@revied
Copy link
Copy Markdown
Contributor

@revied revied commented Apr 10, 2026

Summary

  • golangci-lint v1.62.2 was built with Go 1.23 and errors on projects targeting Go 1.24.2: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.2)
  • Bumps golangci-lint to v1.64.8 (latest v1, built with Go 1.24 support)
  • Updates the GitHub Action from v6.1.1 to v6.5.2

Test plan

  • CI passes on this PR (the linter step should no longer fail)

🤖 Generated with Claude Code

golangci-lint v1.62.2 was built with Go 1.23 and fails on projects
targeting Go 1.24.2. Bumps to v1.64.8 (latest v1) and updates the
GitHub Action to v6.5.2.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@revied revied requested a review from bakayolo as a code owner April 10, 2026 15:12
revied and others added 3 commits April 10, 2026 11:17
Fixes deprecated config options removed in golangci-lint v1.64:
- run.skip-dirs/skip-files -> issues.exclude-dirs/exclude-files
- linters-settings.govet.check-shadowing (removed)
- linters-settings.unused.check-exported (removed)
- output.format -> output.formats, removed uniq-by-line

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The linter was previously broken (Go version mismatch), so existing
code was never linted. Adding only-new-issues prevents pre-existing
lint violations from blocking new PRs while they get cleaned up
separately.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Runs gofmt/goimports on files that were never formatted because CI
was broken. Adds CLAUDE.md to gitignore to prevent accidental commits.
No logic changes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@revied revied force-pushed the fix/golangci-lint-version branch from b06ef9d to dab2b8e Compare April 10, 2026 15:33
@bakayolo
Copy link
Copy Markdown
Collaborator

🤖 Automated Expert Review

Summary

Straightforward linter version bump from golangci-lint v1.62.2 to v1.64.8 to fix Go 1.24 compatibility, plus config migration for deprecated options. All changes are mechanical and correct.


Findings

No blockers or warnings found. Everything looks clean:

  • ✅ GitHub Action SHA-pinned (55c2c1448f86e01eaae002a5a3a9624417608d84 # v6.5.2)
  • ✅ Deprecated config options properly migrated (skip-dirsexclude-dirs, formatformats, removed check-shadowing/check-exported/uniq-by-line)
  • ✅ Modern //go:build directive added alongside legacy // +build
  • ✅ Remaining changes are auto-formatter whitespace adjustments (struct alignment, trailing whitespace)
  • only-new-issues: true added — sensible for incremental adoption

Checklist

Check Status Notes
🔒 Security Action is SHA-pinned
🏗️ Reliability No logic changes
🚀 Staging before Prod N/A CI config only
📦 Atlantis Plan N/A Not infrastructure
🧪 Tests No test logic changes, just formatting
⚙️ CI Checks All passing
💰 Cost/Blast Radius CI-only change

Verdict: APPROVE

Clean version bump with proper config migration. Good to merge.


🤖 Review by Amp agent · not a substitute for human review

Copy link
Copy Markdown
Collaborator

@bakayolo bakayolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🤖 Automated review passed — no blockers found.

@revied revied merged commit 0769c79 into block:main Apr 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants