Fixes for issue 103 and 132 #136
Conversation
|
also added #137 small fix |
I think yes we should allow, perhaps we could displa a warning and add a limitation that if stage 1 has passed then no possibility to invest anymore. @miwahn what do you think? |
| @@ -156,7 +156,7 @@ | |||
| <div class="mb-3"> | |||
| <label class="form-label">The amount in % to allocate for stage @(project.ProjectInfo.Stages.IndexOf(stage) + 1)</label> | |||
| <div class="input-group"> | |||
| <InputNumber @bind-Value="stage.AmountToRelease" class="form-control" placeholder="Enter amount to release as a percentage" min="1" max="100" step="1" /> | |||
| <InputNumber @bind-Value="stage.AmountToRelease" class="form-control" placeholder="Enter amount to release as a percentage" min="0.01" max="100" step="0.01" /> | |||
There was a problem hiding this comment.
do we need to change anything in the validation code? I suppose not.
src/Angor/Client/Pages/Founder.razor
Outdated
| <div class="row mt-4"> | ||
| <div class="card card-body angor-alert-info pt-2 pb-2"> | ||
| <div class="d-flex align-items-center align-items-center"> | ||
| <div class="row mt-4"> |
There was a problem hiding this comment.
same issue here with formatting
|
@DavidGershony this is for you to review |
# Conflicts: # src/Angor/Client/Pages/Invest.razor
|
#132 is still TBD right now it is "disabled" from the view page,
|
| @@ -111,15 +106,16 @@ else | |||
| { | |||
| scanningForProjects = true; | |||
|
|
|||
| // Clear the existing projects before rescan | |||
There was a problem hiding this comment.
Why do we clear the data we already have?
| break; | ||
|
|
||
| case { Kind: NostrKind.ApplicationSpecificData }: | ||
| var projectInfo = serializer.Deserialize<ProjectInfo>(e.Content); |
There was a problem hiding this comment.
Better to keep this comment so it's easier to understand later on
| @@ -93,6 +93,11 @@ public void AddFounderProject(params FounderProject[] projects) | |||
|
|
|||
| _storage.SetItem("founder-projects", ret.OrderBy(_ => _.ProjectIndex)); | |||
| } | |||
|
|
|||
| public void ClearFounderProjects() | |||
There was a problem hiding this comment.
Do we need this when we have DeleteFounderProjects?
Implement Rescan Functionality with Data Clearing for Founder Projects #103
And fix for invest page time and functionality #132
(@dangershony or @DavidGershony there's a TODO comment because i wasn't sure what is expected,
"//TODO: what should the order be here? if an investor has a signed trx that he has not invested yet, and the project has started, could he invest?" "
also i think there is another case of someone requesting to invest, and the founder hasn't signed until after the start date